Re: [PATCH net] rhashtable: prevent work queue schedule while dismantling

2018-10-01 Thread Eric Dumazet
On Mon, Oct 1, 2018 at 6:40 AM Herbert Xu wrote: > > On Mon, Oct 01, 2018 at 06:16:27AM -0700, Eric Dumazet wrote: > > syszbot found an interesting use-after-free [1] happening > > while IPv4 fragment rhashtable was destroyed at netns dismantle. > > > > While no insertions can possibly happen at t

Re: [PATCH net] rhashtable: prevent work queue schedule while dismantling

2018-10-01 Thread Herbert Xu
On Mon, Oct 01, 2018 at 06:16:27AM -0700, Eric Dumazet wrote: > syszbot found an interesting use-after-free [1] happening > while IPv4 fragment rhashtable was destroyed at netns dismantle. > > While no insertions can possibly happen at the time a dismantling > netns is destroying this rhashtable,

[PATCH net] rhashtable: prevent work queue schedule while dismantling

2018-10-01 Thread Eric Dumazet
syszbot found an interesting use-after-free [1] happening while IPv4 fragment rhashtable was destroyed at netns dismantle. While no insertions can possibly happen at the time a dismantling netns is destroying this rhashtable, timers can still fire and attempt to remove elements from this rhashtabl