Re: [PATCH net] rtnetlink: Fail dump if target netnsid is invalid

2018-10-02 Thread David Ahern
On 10/2/18 4:04 AM, Jiri Benc wrote: > On Fri, 28 Sep 2018 12:28:41 -0700, David Ahern wrote: >> --- a/net/core/rtnetlink.c >> +++ b/net/core/rtnetlink.c >> @@ -1898,10 +1898,8 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, >> struct netlink_callback *cb) >> if (tb[IFLA_IF_NETNSI

Re: [PATCH net] rtnetlink: Fail dump if target netnsid is invalid

2018-10-02 Thread Jiri Benc
On Fri, 28 Sep 2018 12:28:41 -0700, David Ahern wrote: > --- a/net/core/rtnetlink.c > +++ b/net/core/rtnetlink.c > @@ -1898,10 +1898,8 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, > struct netlink_callback *cb) > if (tb[IFLA_IF_NETNSID]) { > netnsid = nla

Re: [PATCH net] rtnetlink: Fail dump if target netnsid is invalid

2018-10-01 Thread David Miller
From: David Ahern Date: Fri, 28 Sep 2018 12:28:41 -0700 > From: David Ahern > > Link dumps can return results from a target namespace. If the namespace id > is invalid, then the dump request should fail if get_target_net fails > rather than continuing with a dump of the current namespace. > >

[PATCH net] rtnetlink: Fail dump if target netnsid is invalid

2018-09-28 Thread David Ahern
From: David Ahern Link dumps can return results from a target namespace. If the namespace id is invalid, then the dump request should fail if get_target_net fails rather than continuing with a dump of the current namespace. Fixes: 79e1ad148c844 ("rtnetlink: use netnsid to query interface") Signe