Re: [PATCH net] sch_sfq: fix null pointer dereference at timer expiration

2017-11-28 Thread David Miller
From: Paolo Abeni Date: Tue, 28 Nov 2017 14:28:39 +0100 > While converting sch_sfq to use timer_setup(), the commit cdeabbb88134 > ("net: sched: Convert timers to use timer_setup()") forgot to > initialize the 'sch' field. As a result, the timer callback tries to > dereference a NULL pointer, and

Re: [PATCH net] sch_sfq: fix null pointer dereference at timer expiration

2017-11-28 Thread Kees Cook
On Tue, Nov 28, 2017 at 9:50 AM, Cong Wang wrote: > On Tue, Nov 28, 2017 at 5:28 AM, Paolo Abeni wrote: >> While converting sch_sfq to use timer_setup(), the commit cdeabbb88134 >> ("net: sched: Convert timers to use timer_setup()") forgot to >> initialize the 'sch' field. As a result, the timer

Re: [PATCH net] sch_sfq: fix null pointer dereference at timer expiration

2017-11-28 Thread Cong Wang
On Tue, Nov 28, 2017 at 5:28 AM, Paolo Abeni wrote: > While converting sch_sfq to use timer_setup(), the commit cdeabbb88134 > ("net: sched: Convert timers to use timer_setup()") forgot to > initialize the 'sch' field. As a result, the timer callback tries to > dereference a NULL pointer, and the

[PATCH net] sch_sfq: fix null pointer dereference at timer expiration

2017-11-28 Thread Paolo Abeni
While converting sch_sfq to use timer_setup(), the commit cdeabbb88134 ("net: sched: Convert timers to use timer_setup()") forgot to initialize the 'sch' field. As a result, the timer callback tries to dereference a NULL pointer, and the kernel does oops. Fix it initializing such field at qdisc cr