Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-13 Thread 'Marcelo Ricardo Leitner'
On Wed, Feb 13, 2019 at 04:17:41PM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 10 February 2019 20:16 > ... > > We have issues on read path too. 52ccb8e90c0a ("[SCTP]: Update > > SCTP_PEER_ADDR_PARAMS socket option to the latest api draft.") > > extended struct sctp_paddrpa

RE: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-13 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 10 February 2019 20:16 ... > We have issues on read path too. 52ccb8e90c0a ("[SCTP]: Update > SCTP_PEER_ADDR_PARAMS socket option to the latest api draft.") > extended struct sctp_paddrparams and its getsockopt goes with: The API shouldn't change like this at

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-11 Thread Marcelo Ricardo Leitner
On Mon, Feb 11, 2019 at 10:04:32AM -0500, Neil Horman wrote: > On Sun, Feb 10, 2019 at 10:46:16AM -0200, Marcelo Ricardo Leitner wrote: > > On Sat, Feb 09, 2019 at 03:12:17PM -0800, David Miller wrote: > > > From: Marcelo Ricardo Leitner > > > Date: Wed, 6 Feb 2019 18:37:54 -0200 > > > > > > > On

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-11 Thread Neil Horman
On Sun, Feb 10, 2019 at 10:46:16AM -0200, Marcelo Ricardo Leitner wrote: > On Sat, Feb 09, 2019 at 03:12:17PM -0800, David Miller wrote: > > From: Marcelo Ricardo Leitner > > Date: Wed, 6 Feb 2019 18:37:54 -0200 > > > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > > >> Make s

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-10 Thread Marcelo Ricardo Leitner
On Sun, Feb 10, 2019 at 10:46:16AM -0200, Marcelo Ricardo Leitner wrote: > On Sat, Feb 09, 2019 at 03:12:17PM -0800, David Miller wrote: > > From: Marcelo Ricardo Leitner > > Date: Wed, 6 Feb 2019 18:37:54 -0200 > > > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > > >> Make s

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-10 Thread Marcelo Ricardo Leitner
On Sat, Feb 09, 2019 at 03:12:17PM -0800, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 6 Feb 2019 18:37:54 -0200 > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > >> Make sctp_setsockopt_events() able to accept sctp_event_subscribe > >> structures longer th

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-09 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 6 Feb 2019 18:37:54 -0200 > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: >> Make sctp_setsockopt_events() able to accept sctp_event_subscribe >> structures longer than the current definitions. >> >> This should prevent unjustified setsock

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-08 Thread Neil Horman
On Fri, Feb 08, 2019 at 09:53:03AM +, David Laight wrote: > From: 'Marcelo Ricardo Leitner' > > Sent: 07 February 2019 17:47 > ... > > > > Maybe what we want(ed) here then is explicit versioning, to have the 3 > > > > definitions available. Then the application is able to use, say struct > > >

RE: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-08 Thread David Laight
From: 'Marcelo Ricardo Leitner' > Sent: 07 February 2019 17:47 ... > > > Maybe what we want(ed) here then is explicit versioning, to have the 3 > > > definitions available. Then the application is able to use, say struct > > > sctp_event_subscribe, and be happy with it, while there is struct > > >

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-07 Thread 'Marcelo Ricardo Leitner'
On Thu, Feb 07, 2019 at 05:33:07PM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 06 February 2019 21:07 > > > > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > > > > > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > > > On Wed, Feb 06, 2019 at

RE: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-07 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 06 February 2019 21:07 > > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > > >> Make sctp_setsockopt_events() abl

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-07 Thread Neil Horman
On Wed, Feb 06, 2019 at 01:48:44PM -0800, Julien Gomes wrote: > > > On 2/6/19 1:39 PM, Neil Horman wrote: > > On Wed, Feb 06, 2019 at 01:26:55PM -0800, Julien Gomes wrote: > >> > >> > >> On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: > >>> On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-07 Thread Neil Horman
On Wed, Feb 06, 2019 at 01:48:42PM -0800, Julien Gomes wrote: > > > On 2/6/19 1:23 PM, Neil Horman wrote: > > On Wed, Feb 06, 2019 at 07:07:23PM -0200, Marcelo Ricardo Leitner wrote: > >> On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > >>> > >>> > >>> On 2/6/19 12:37 PM, Marcelo R

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:48 PM, Julien Gomes wrote: > > > On 2/6/19 1:39 PM, Neil Horman wrote: >> On Wed, Feb 06, 2019 at 01:26:55PM -0800, Julien Gomes wrote: >>> >>> >>> On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > >

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:23 PM, Neil Horman wrote: > On Wed, Feb 06, 2019 at 07:07:23PM -0200, Marcelo Ricardo Leitner wrote: >> On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: >>> >>> >>> On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien G

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:39 PM, Neil Horman wrote: > On Wed, Feb 06, 2019 at 01:26:55PM -0800, Julien Gomes wrote: >> >> >> On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: >>> On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: >>>

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Neil Horman
On Wed, Feb 06, 2019 at 01:26:55PM -0800, Julien Gomes wrote: > > > On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: > > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > >> > >> > >> On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > >>> On Wed, Feb 06, 2019 at 12:14:30PM -0800,

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: >> >> >> On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: >>> On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: Make sctp_setsockopt_events() able to accept sctp_e

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Neil Horman
On Wed, Feb 06, 2019 at 07:07:23PM -0200, Marcelo Ricardo Leitner wrote: > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > > >> Make sctp_setsockopt_e

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Marcelo Ricardo Leitner
On Wed, Feb 06, 2019 at 04:08:27PM -0500, Neil Horman wrote: > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > > >> Make sctp_setsockopt_events() able

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Neil Horman
On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > >> Make sctp_setsockopt_events() able to accept sctp_event_subscribe > >> structures longer than the current d

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Marcelo Ricardo Leitner
On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > >> Make sctp_setsockopt_events() able to accept sctp_event_subscribe > >> structures longer than the current d

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Neil Horman
On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > Make sctp_setsockopt_events() able to accept sctp_event_subscribe > structures longer than the current definitions. > > This should prevent unjustified setsockopt() failures due to struct > sctp_event_subscribe extensions (as in 4.11

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: >> Make sctp_setsockopt_events() able to accept sctp_event_subscribe >> structures longer than the current definitions. >> >> This should prevent unjustified setsockopt() failures d

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Marcelo Ricardo Leitner
On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > Make sctp_setsockopt_events() able to accept sctp_event_subscribe > structures longer than the current definitions. > > This should prevent unjustified setsockopt() failures due to struct > sctp_event_subscribe extensions (as in 4.11

[PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
Make sctp_setsockopt_events() able to accept sctp_event_subscribe structures longer than the current definitions. This should prevent unjustified setsockopt() failures due to struct sctp_event_subscribe extensions (as in 4.11 and 4.12) when using binaries that should be compatible, but were built