Re: [PATCH net] selftests/net: Fixes psock_fanout CBPF test case

2017-04-20 Thread David Miller
From: Mike Maloney Date: Tue, 18 Apr 2017 11:14:16 -0400 > From: Mike Maloney > > 'psock_fanout' has been failing since commit 4d7b9dc1f36a9 ("tools: > psock_lib: harden socket filter used by psock tests"). That commit > changed the CBPF filter to examine the full ethernet frame, and was > tes

Re: [PATCH net] selftests/net: Fixes psock_fanout CBPF test case

2017-04-18 Thread Sowmini Varadhan
On (04/18/17 11:56), Mike Maloney wrote: > I am not 100% sure what you are asking for, as the instructions you > can feed to bpf_asm are already commented to the right of the program. oh, right, I missed that you had commented the BPF_STMT macros with the equivalent bpf_asm inovcation. Looks goo

Re: [PATCH net] selftests/net: Fixes psock_fanout CBPF test case

2017-04-18 Thread Mike Maloney
On Tue, Apr 18, 2017 at 11:26 AM, Sowmini Varadhan wrote: > On (04/18/17 11:14), Mike Maloney wrote: >> Change 'psock_fanout' to use SOCK_RAW so that the CBPF program used with >> SO_ATTACH_FILTER can examine the entire frame. Create a new CBPF >> program for use with PACKET_FANOUT_DATA which ign

Re: [PATCH net] selftests/net: Fixes psock_fanout CBPF test case

2017-04-18 Thread Sowmini Varadhan
On (04/18/17 11:14), Mike Maloney wrote: > Change 'psock_fanout' to use SOCK_RAW so that the CBPF program used with > SO_ATTACH_FILTER can examine the entire frame. Create a new CBPF > program for use with PACKET_FANOUT_DATA which ignores the header, as it > cannot see the ethernet header. Fix lo

[PATCH net] selftests/net: Fixes psock_fanout CBPF test case

2017-04-18 Thread Mike Maloney
From: Mike Maloney 'psock_fanout' has been failing since commit 4d7b9dc1f36a9 ("tools: psock_lib: harden socket filter used by psock tests"). That commit changed the CBPF filter to examine the full ethernet frame, and was tested on 'psock_tpacket' which uses SOCK_RAW. But 'psock_fanout' was als