Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-26 Thread Stephen Hemminger
On Thu, 25 May 2017 23:58:30 -0400 (EDT) David Miller wrote: > From: Stephen Hemminger > Date: Thu, 25 May 2017 15:05:02 -0700 > > > Ok, the issue is that lockdep is being stupid and thinking that > > seqcount's behave like locks. > > Well.. they do. That's why they have that annotation. Y

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread David Miller
From: Stephen Hemminger Date: Thu, 25 May 2017 15:05:02 -0700 > Ok, the issue is that lockdep is being stupid and thinking that > seqcount's behave like locks. Well.. they do. That's why they have that annotation.

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread Francois Romieu
David Miller : > From: Joshua Emele > Date: Wed, 24 May 2017 15:43:18 -0700 [...] > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in > > the HW queue. Because sky2_hw_down can be called from a process context, > > the call to u64_stats_update_begin can result in deadlock.

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread Stephen Hemminger
On Thu, 25 May 2017 13:21:58 -0700 Joshua Emele wrote: > On Thu, May 25, 2017 at 10:54 AM, Stephen Hemminger > wrote: > > > > On Wed, 24 May 2017 15:43:18 -0700 > > Joshua Emele wrote: > > > > > From: Joshua Emele > > > > > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuc

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread Joshua Emele
On Thu, May 25, 2017 at 10:54 AM, Stephen Hemminger wrote: > > On Wed, 24 May 2017 15:43:18 -0700 > Joshua Emele wrote: > > > From: Joshua Emele > > > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in > > the HW queue. Because sky2_hw_down can be called from a process cont

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread Stephen Hemminger
On Wed, 24 May 2017 15:43:18 -0700 Joshua Emele wrote: > From: Joshua Emele > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in > the HW queue. Because sky2_hw_down can be called from a process context, > the call to u64_stats_update_begin can result in deadlock. > > Bec

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-25 Thread David Miller
From: Joshua Emele Date: Wed, 24 May 2017 15:43:18 -0700 > From: Joshua Emele > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in > the HW queue. Because sky2_hw_down can be called from a process context, > the call to u64_stats_update_begin can result in deadlock. > > B

[PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-24 Thread Joshua Emele
From: Joshua Emele The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in the HW queue. Because sky2_hw_down can be called from a process context, the call to u64_stats_update_begin can result in deadlock. Because the statistics do not require update as part of the sky2_hw_down s