Re: [PATCH net] sock_diag: invert socket destroy broadcast check

On Fri, Jun 24, 2016 at 6:22 PM, Willem de Bruijn wrote: > On Fri, Jun 24, 2016 at 4:41 PM, Eric W. Biederman > wrote: >> Willem de Bruijn writes: >> >>> From: Willem de Bruijn >>> >>> Socket destruction is only broadcast for a socket sk if a diag >>> listener is registered and sk is not a kern

Re: [PATCH net] sock_diag: invert socket destroy broadcast check

On Fri, Jun 24, 2016 at 4:41 PM, Eric W. Biederman wrote: > Willem de Bruijn writes: > >> From: Willem de Bruijn >> >> Socket destruction is only broadcast for a socket sk if a diag >> listener is registered and sk is not a kernel socket. >> >> Invert the test to not even check for listeners for

Re: [PATCH net] sock_diag: invert socket destroy broadcast check

Willem de Bruijn writes: > From: Willem de Bruijn > > Socket destruction is only broadcast for a socket sk if a diag > listener is registered and sk is not a kernel socket. > > Invert the test to not even check for listeners for kernel sockets. > > The sock_diag_has_destroy_listeners invocation

[PATCH net] sock_diag: invert socket destroy broadcast check

From: Willem de Bruijn Socket destruction is only broadcast for a socket sk if a diag listener is registered and sk is not a kernel socket. Invert the test to not even check for listeners for kernel sockets. The sock_diag_has_destroy_listeners invocation dereferences sock_net(sk), which for ker