Re: [PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread David Miller
From: Michael Chan Date: Wed, 14 Mar 2018 10:22:51 -0700 > On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: >> The problem was introduced in commit >> 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs >> because tp->lock

Re: [PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread Jonathan Toppins
On 03/14/2018 01:22 PM, Michael Chan wrote: > On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: >> The problem was introduced in commit >> 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs >> because tp->lock spinlock is held which is obtained in

Re: [PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread Michael Chan
On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: > The problem was introduced in commit > 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs > because tp->lock spinlock is held which is obtained in tg3_start > by way of tg3_full_lock(), line 11571.

[PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread Jonathan Toppins
The problem was introduced in commit 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs because tp->lock spinlock is held which is obtained in tg3_start by way of tg3_full_lock(), line 11571. The documentation for usleep_range() specifically states it cannot be used inside a