Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-24 Thread David Shwatrz
Hello, First, it indeed can be handled by user space. (even though it should be done twice, once for ifconig of net-tools and once for ip of iproute2) / However, we have already methods which deal with bringing down an interface - neigh_ifdown(), and changing MAC address of an interface

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-24 Thread jamal
On Sun, 2007-23-12 at 08:17 -0500, jamal wrote: On Sun, 2007-23-12 at 22:04 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: If the secondary MACs are used with ARP/NDP, we should take care of that, but I think we use the primary MAC for ARP/NDP, no? (In other words, we always use primary MAC for

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-24 Thread jamal
On Mon, 2007-24-12 at 15:38 +0200, David Shwatrz wrote: Hello, First, it indeed can be handled by user space. (even though it should be done twice, once for ifconig of net-tools and once for ip of iproute2) it needs to be done once only: reacting to netlink events when MAC address

[PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread David Shwatrz
Hello, Attached here is the patch - please read the following text here below: We know that changes in MAC addresses are not frequent but we are working on a special, highly advanced networking Linux based project in our LABs, where we do change MAC addresses of an interface quite frequently.

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Sun, 23 Dec 2007 13:41:36 +0200), David Shwatrz [EMAIL PROTECTED] says: I had written a small patch to neigh_changeaddr() in net/core/neighbour.c against the 2.6 git net tree, which sends a gratuitous ARP to update the list of all the involved neighbours with

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread David Shwatrz
Hi, Oop, I am TWICE sorry ! I wrongly attached a wrong, empty file. Attached here is the patch. Regarding your answer; I accept it and I will soon send a revised version of this patch (making changes to arp_netdev_event() and ndisc_netdev_event().) I had IPv4 in mind, there is no reason that

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Sun, 23 Dec 2007 14:24:00 +0200), David Shwatrz [EMAIL PROTECTED] says: Regarding your answer; I accept it and I will soon send a revised version of this patch (making changes to arp_netdev_event() and ndisc_netdev_event().) I had IPv4 in mind, there is no

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread jamal
On Sun, 2007-23-12 at 21:38 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Sun, 23 Dec 2007 14:24:00 +0200), David Shwatrz [EMAIL PROTECTED] says: Regarding your answer; I accept it and I will soon send a revised version of this patch (making changes to

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Sun, 23 Dec 2007 07:46:15 -0500), jamal [EMAIL PROTECTED] says: On Sun, 2007-23-12 at 21:38 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Sun, 23 Dec 2007 14:24:00 +0200), David Shwatrz [EMAIL PROTECTED] says: Regarding your

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread David Shwatrz
Hello, You should iterate all of ifa_list (for IPv4) / addr_list (for IPv6). For IPv6, we also have anycast (maintained by ac_list) as well. I am not sure that we need to iterate all of ifa_list in IPv4. The reason is that we end with arp_send, and it initiates a broadcast. So all neighbours

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Sun, 23 Dec 2007 15:04:37 +0200), David Shwatrz [EMAIL PROTECTED] says: Hello, You should iterate all of ifa_list (for IPv4) / addr_list (for IPv6). For IPv6, we also have anycast (maintained by ac_list) as well. I am not sure that we need to iterate

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread jamal
On Sun, 2007-23-12 at 22:04 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: If the secondary MACs are used with ARP/NDP, we should take care of that, but I think we use the primary MAC for ARP/NDP, no? (In other words, we always use primary MAC for ARP reply / NA, no?) I think it maybe a policy

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread David Shwatrz
Yoshfuji, Thanks, you are right ! soon I will send the patches. Thanks ! DS On Dec 23, 2007 3:13 PM, YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote: In article [EMAIL PROTECTED] (at Sun, 23 Dec 2007 15:04:37 +0200), David Shwatrz [EMAIL PROTECTED] says: Hello, You should iterate

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread Herbert Xu
David Shwatrz [EMAIL PROTECTED] wrote: Hi, Oop, I am TWICE sorry ! I wrongly attached a wrong, empty file. Attached here is the patch. Regarding your answer; I accept it and I will soon send a revised version of this patch (making changes to arp_netdev_event() and ndisc_netdev_event().)