Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-04 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Wed, 3 Oct 2007, Cedric Le Goater wrote: > >> Cedric Le Goater wrote: >>> Below are the messages I got on 2) right after running ketchup (which does >>> a wget www.kernel.org) > > Oops, those tcp_fragment WARNINGs in the other mail were due to bug in > the debug patch

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-04 Thread Ilpo Järvinen
On Wed, 3 Oct 2007, Cedric Le Goater wrote: > Cedric Le Goater wrote: > > > > Below are the messages I got on 2) right after running ketchup (which does > > a wget www.kernel.org) Oops, those tcp_fragment WARNINGs in the other mail were due to bug in the debug patch as it called verify too ea

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Cedric Le Goater
Cedric Le Goater wrote: > Ilpo Järvinen wrote: >> On Wed, 3 Oct 2007, Cedric Le Goater wrote: >> >>> Ilpo Järvinen wrote: Ah, that's path 1) then... Since you seem to have enough time, I would say that the path 1 is good as well and bugs unrelated to the fix will show up there too.

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Wed, 3 Oct 2007, Cedric Le Goater wrote: > >> Ilpo Järvinen wrote: >>> Ah, that's path 1) then... Since you seem to have enough time, I would say >>> that the path 1 is good as well and bugs unrelated to the fix will show up >>> there too... >> arg. yes. sorry for the c

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Cedric Le Goater
Cedric Le Goater wrote: > Ilpo Järvinen wrote: >> On Wed, 3 Oct 2007, Cedric Le Goater wrote: >> >>> Ilpo Järvinen wrote: Ah, that's path 1) then... Since you seem to have enough time, I would say that the path 1 is good as well and bugs unrelated to the fix will show up there too.

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Ilpo Järvinen
On Wed, 3 Oct 2007, Cedric Le Goater wrote: > Ilpo Järvinen wrote: > > > > Ah, that's path 1) then... Since you seem to have enough time, I would say > > that the path 1 is good as well and bugs unrelated to the fix will show up > > there too... > > arg. yes. sorry for the confusion. > > > I

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Wed, 3 Oct 2007, Cedric Le Goater wrote: > >> Ilpo Järvinen wrote: >>> On Wed, 3 Oct 2007, Cedric Le Goater wrote: >>> I'm dropping the previous patches you sent me and switching to this patchset. right ? >>> Yes you can do that... However, there are two

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Ilpo Järvinen
On Wed, 3 Oct 2007, Cedric Le Goater wrote: > Ilpo Järvinen wrote: > > On Wed, 3 Oct 2007, Cedric Le Goater wrote: > > > >> I'm dropping the previous patches you sent me and switching to this > >> patchset. > >> right ? > > > > Yes you can do that... However, there are two ways forward: > > >

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Wed, 3 Oct 2007, Cedric Le Goater wrote: > >> Ilpo Järvinen wrote: >>> Sacktag fastpath_cnt_hint seems to be very tricky to get right... >>> I suppose this one fixes Cedric's case. I cannot say for sure >>> until there is something more definite indication of >>> tcp_

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Ilpo Järvinen
On Wed, 3 Oct 2007, Cedric Le Goater wrote: > Ilpo Järvinen wrote: > > Sacktag fastpath_cnt_hint seems to be very tricky to get right... > > I suppose this one fixes Cedric's case. I cannot say for sure > > until there is something more definite indication of > > tcp_retrans_try_collapse origi

Re: [PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Cedric Le Goater
Hello Ilpo ! Ilpo Järvinen wrote: > Hi Dave, > > Sacktag fastpath_cnt_hint seems to be very tricky to get right... > I suppose this one fixes Cedric's case. I cannot say for sure > until there is something more definite indication of > tcp_retrans_try_collapse origin than what the simple late

[PATCH net-2.6.24 0/3]: More TCP fixes

2007-10-03 Thread Ilpo Järvinen
Hi Dave, Sacktag fastpath_cnt_hint seems to be very tricky to get right... I suppose this one fixes Cedric's case. I cannot say for sure until there is something more definite indication of tcp_retrans_try_collapse origin than what the simple late WARN_ON gave for us. ...Especially since it's