Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Eric Dumazet
On 04/24/2018 08:59 AM, Yafang Shao wrote: > On Tue, Apr 24, 2018 at 11:49 PM, Eric Dumazet wrote: >> >> >> On 04/24/2018 08:12 AM, Yafang Shao wrote: >>> On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet >>> wrote: On 04/24/2018 05:05 AM, Yafang Shao wrote: > This revert commit

Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Yafang Shao
On Tue, Apr 24, 2018 at 11:49 PM, Eric Dumazet wrote: > > > On 04/24/2018 08:12 AM, Yafang Shao wrote: >> On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet wrote: >>> >>> >>> On 04/24/2018 05:05 AM, Yafang Shao wrote: This revert commit ("net: init sk_cookie for inet socket") Per disc

Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Eric Dumazet
On 04/24/2018 08:12 AM, Yafang Shao wrote: > On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet wrote: >> >> >> On 04/24/2018 05:05 AM, Yafang Shao wrote: >>> This revert commit ("net: init sk_cookie for inet socket") >>> >>> Per discussion with Eric. >>> >> >> I suggest you include a bit more detai

Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Yafang Shao
On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet wrote: > > > On 04/24/2018 05:05 AM, Yafang Shao wrote: >> This revert commit ("net: init sk_cookie for inet socket") >> >> Per discussion with Eric. >> > > I suggest you include a bit more details, about cache line false sharing. > Coud we adjust th

Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Yafang Shao
On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet wrote: > > > On 04/24/2018 05:05 AM, Yafang Shao wrote: >> This revert commit ("net: init sk_cookie for inet socket") >> >> Per discussion with Eric. >> > > I suggest you include a bit more details, about cache line false sharing. > > Thanks. > OK. w

Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Eric Dumazet
On 04/24/2018 05:05 AM, Yafang Shao wrote: > This revert commit ("net: init sk_cookie for inet socket") > > Per discussion with Eric. > I suggest you include a bit more details, about cache line false sharing. Thanks.

[PATCH net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Yafang Shao
This revert commit ("net: init sk_cookie for inet socket") Per discussion with Eric. Signed-off-by: Yafang Shao --- include/linux/sock_diag.h | 9 - net/ipv4/tcp_input.c | 8 +--- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/include/linux/sock_diag.h b/includ