Re: [PATCH net-next] Revert "vxlan: move encapsulation warning"

2020-10-01 Thread Fabian Frederick
> On 30/09/2020 18:29 Jakub Kicinski wrote: > > > On Wed, 30 Sep 2020 18:20:05 +0200 (CEST) Fabian Frederick wrote: > > Thanks a lot for explanations Jakub. udp_tunnel_nic.sh is a nice > > tool. Maybe it could also be used for remcsum testing ? I'd like to > > check net-next commit 2ae2904b5b

Re: [PATCH net-next] Revert "vxlan: move encapsulation warning"

2020-09-30 Thread Jakub Kicinski
On Wed, 30 Sep 2020 18:20:05 +0200 (CEST) Fabian Frederick wrote: > Thanks a lot for explanations Jakub. udp_tunnel_nic.sh is a nice > tool. Maybe it could also be used for remcsum testing ? I'd like to > check net-next commit 2ae2904b5bac "vxlan: don't collect metadata if > remote checksum is wron

Re: [PATCH net-next] Revert "vxlan: move encapsulation warning"

2020-09-30 Thread Fabian Frederick
> On 26/09/2020 03:56 Jakub Kicinski wrote: > > > This reverts commit 546c044c9651e81a16833806feff6b369bb5de33. > > Nothing prevents user from sending frames to "external" VxLAN devices. > In fact kernel itself may generate icmp chatter. > > This is fine, such frames should be dropped. > >

Re: [PATCH net-next] Revert "vxlan: move encapsulation warning"

2020-09-26 Thread David Miller
From: Jakub Kicinski Date: Fri, 25 Sep 2020 18:56:04 -0700 > This reverts commit 546c044c9651e81a16833806feff6b369bb5de33. > > Nothing prevents user from sending frames to "external" VxLAN devices. > In fact kernel itself may generate icmp chatter. > > This is fine, such frames should be droppe

[PATCH net-next] Revert "vxlan: move encapsulation warning"

2020-09-25 Thread Jakub Kicinski
This reverts commit 546c044c9651e81a16833806feff6b369bb5de33. Nothing prevents user from sending frames to "external" VxLAN devices. In fact kernel itself may generate icmp chatter. This is fine, such frames should be dropped. The point of the "missing encapsulation" warning was that frames with