Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-05-01 Thread Jiri Pirko
Thu, Apr 28, 2016 at 05:54:19PM CEST, da...@davemloft.net wrote: >From: Nicolas Dichtel >Date: Thu, 28 Apr 2016 13:59:34 +0200 > >> Le 27/04/2016 18:55, David Miller a écrit : >>> From: Jiri Pirko >> [snip] The difference is that it this tries to allow userspace crap to mirror setting u

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-05-01 Thread Jiri Pirko
Fri, Apr 29, 2016 at 10:48:17AM CEST, nicolas.dich...@6wind.com wrote: >Le 28/04/2016 17:54, David Miller a écrit : >[snip] >> You can say whatever you want, but the facilities you are adding to >> this driver enables proprietary userland SDK components. >> >> And this is precisely what we are try

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-05-01 Thread Jiri Pirko
Thu, Apr 28, 2016 at 01:59:34PM CEST, nicolas.dich...@6wind.com wrote: >Le 27/04/2016 18:55, David Miller a écrit : >> From: Jiri Pirko >[snip] >>> The difference is that it this tries to allow userspace crap to mirror >>> setting user does for bridge/ovs. Basically this looks to me like an >>> at

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-29 Thread Nicolas Dichtel
Le 28/04/2016 17:54, David Miller a écrit : [snip] > You can say whatever you want, but the facilities you are adding to > this driver enables proprietary userland SDK components. > > And this is precisely what we are trying to avoid by having a clean, > fully featured switch device model in the k

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-28 Thread David Miller
From: Nicolas Dichtel Date: Thu, 28 Apr 2016 13:59:34 +0200 > Le 27/04/2016 18:55, David Miller a écrit : >> From: Jiri Pirko > [snip] >>> The difference is that it this tries to allow userspace crap to mirror >>> setting user does for bridge/ovs. Basically this looks to me like an >>> attempt t

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-28 Thread Or Gerlitz
On Thu, Apr 28, 2016, Nicolas Dichtel wrote: > Le 27/04/2016 18:55, David Miller a écrit : >> From: Jiri Pirko >>> The difference is that it this tries to allow userspace crap to mirror >>> setting user does for bridge/ovs. Basically this looks to me like an >>> attempt to enable userspace SDKs

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-28 Thread Nicolas Dichtel
Le 27/04/2016 19:07, Stephen Hemminger a écrit : [snip] > Also it has a bunch of device specific generic netlink which was > a red flag for me. > Ok, I will rework this part.

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-28 Thread Nicolas Dichtel
Le 27/04/2016 18:55, David Miller a écrit : > From: Jiri Pirko [snip] >> The difference is that it this tries to allow userspace crap to mirror >> setting user does for bridge/ovs. Basically this looks to me like an >> attempt to enable userspace SDKs and such. > > +1 I don't think so because a u

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-27 Thread Stephen Hemminger
On Wed, 27 Apr 2016 12:55:06 -0400 (EDT) David Miller wrote: > From: Jiri Pirko > Date: Wed, 27 Apr 2016 17:14:04 +0200 > > > Wed, Apr 27, 2016 at 11:56:15AM CEST, f...@strlen.de wrote: > >>Nicolas Dichtel wrote: > >>> This patch adds the support of the 6WIND SHULTI switch. It is a software >

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-27 Thread David Miller
From: Jiri Pirko Date: Wed, 27 Apr 2016 17:14:04 +0200 > Wed, Apr 27, 2016 at 11:56:15AM CEST, f...@strlen.de wrote: >>Nicolas Dichtel wrote: >>> This patch adds the support of the 6WIND SHULTI switch. It is a software >>> switch doing L2 forwarding. >>> >>> This first version implements the mi

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-27 Thread David Miller
From: Nicolas Dichtel Date: Wed, 27 Apr 2016 11:37:18 +0200 > +/* rtnl linkinfo attributes */ > +enum { > + IFLA_SHULTI_UNSPEC, > + IFLA_SHULTI_SWDEV_ID, > + IFLA_SHULTI_SWDEV_PORTID, > + IFLA_SHULTI_PHYS_PORT_NAME, > + > + __IFLA_SHULTI_MAX > +#define IFLA_SHULTI_MAX (__

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-27 Thread Jiri Pirko
Wed, Apr 27, 2016 at 05:38:09PM CEST, nicolas.dich...@6wind.com wrote: >Le 27/04/2016 17:14, Jiri Pirko a écrit : >> Wed, Apr 27, 2016 at 11:56:15AM CEST, f...@strlen.de wrote: >>> Nicolas Dichtel wrote: This patch adds the support of the 6WIND SHULTI switch. It is a software switch doin

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-27 Thread Nicolas Dichtel
Le 27/04/2016 17:14, Jiri Pirko a écrit : > Wed, Apr 27, 2016 at 11:56:15AM CEST, f...@strlen.de wrote: >> Nicolas Dichtel wrote: >>> This patch adds the support of the 6WIND SHULTI switch. It is a software >>> switch doing L2 forwarding. >>> >>> This first version implements the minimum needed to

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-27 Thread Jiri Pirko
Wed, Apr 27, 2016 at 11:56:15AM CEST, f...@strlen.de wrote: >Nicolas Dichtel wrote: >> This patch adds the support of the 6WIND SHULTI switch. It is a software >> switch doing L2 forwarding. >> >> This first version implements the minimum needed to get the device working. >> It also implements, v

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-27 Thread Florian Westphal
Nicolas Dichtel wrote: > This patch adds the support of the 6WIND SHULTI switch. It is a software > switch doing L2 forwarding. > > This first version implements the minimum needed to get the device working. > It also implements, via switchdev and rtnetlink, bridge forwarding offload, > including

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-27 Thread Jiri Pirko
Wed, Apr 27, 2016 at 11:37:18AM CEST, nicolas.dich...@6wind.com wrote: >This patch adds the support of the 6WIND SHULTI switch. It is a software >switch doing L2 forwarding. > >This first version implements the minimum needed to get the device working. >It also implements, via switchdev and rtnetli

[PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-04-27 Thread Nicolas Dichtel
This patch adds the support of the 6WIND SHULTI switch. It is a software switch doing L2 forwarding. This first version implements the minimum needed to get the device working. It also implements, via switchdev and rtnetlink, bridge forwarding offload, including FDB static entries, FDB learning an