Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR

2018-03-22 Thread David Miller
From: Nicolas Dichtel Date: Tue, 20 Mar 2018 18:04:53 +0100 > As the comment said, this attribute defines the originator of the rule, > it's not really a (network) protocol. > Let's rename it accordingly to avoid confusion (difference between > FRA_PROTOCOL and FRA_IP_PROTO was not obvious). > >

Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR

2018-03-21 Thread Nicolas Dichtel
Le 21/03/2018 à 16:15, David Miller a écrit : > From: David Ahern > Date: Wed, 21 Mar 2018 09:00:09 -0600 > >> The rule->proto value is not used as a selector. It is passed in, stored >> on a rule and returned to userspace. It is book keeping only so an admin >> has some idea of which program ins

Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR

2018-03-21 Thread David Miller
From: David Ahern Date: Wed, 21 Mar 2018 09:00:09 -0600 > The rule->proto value is not used as a selector. It is passed in, stored > on a rule and returned to userspace. It is book keeping only so an admin > has some idea of which program installed the rule. This is how I understand this value t

Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR

2018-03-21 Thread David Ahern
On 3/21/18 3:24 AM, Nicolas Dichtel wrote: > Le 20/03/2018 à 18:27, David Ahern a écrit : >> On 3/20/18 11:04 AM, Nicolas Dichtel wrote: >>> As the comment said, this attribute defines the originator of the rule, >>> it's not really a (network) protocol. >>> Let's rename it accordingly to avoid con

Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR

2018-03-21 Thread Nicolas Dichtel
Le 20/03/2018 à 18:27, David Ahern a écrit : > On 3/20/18 11:04 AM, Nicolas Dichtel wrote: >> As the comment said, this attribute defines the originator of the rule, >> it's not really a (network) protocol. >> Let's rename it accordingly to avoid confusion (difference between >> FRA_PROTOCOL and FR

Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR

2018-03-20 Thread David Ahern
On 3/20/18 11:04 AM, Nicolas Dichtel wrote: > As the comment said, this attribute defines the originator of the rule, > it's not really a (network) protocol. > Let's rename it accordingly to avoid confusion (difference between > FRA_PROTOCOL and FRA_IP_PROTO was not obvious). > > CC: Donald Sharp

[PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR

2018-03-20 Thread Nicolas Dichtel
As the comment said, this attribute defines the originator of the rule, it's not really a (network) protocol. Let's rename it accordingly to avoid confusion (difference between FRA_PROTOCOL and FRA_IP_PROTO was not obvious). CC: Donald Sharp Signed-off-by: Nicolas Dichtel --- FRA_PROTOCOL exist