Re: [PATCH net-next] ip: silence udp zerocopy smatch false positive

2018-12-08 Thread David Miller
From: Willem de Bruijn Date: Sat, 8 Dec 2018 06:22:46 -0500 > From: Willem de Bruijn > > extra_uref is used in __ip(6)_append_data only if uarg is set. > > Smatch sees that the variable is passed to sock_zerocopy_put_abort. > This function accesses it only when uarg is set, but smatch cannot

[PATCH net-next] ip: silence udp zerocopy smatch false positive

2018-12-08 Thread Willem de Bruijn
From: Willem de Bruijn extra_uref is used in __ip(6)_append_data only if uarg is set. Smatch sees that the variable is passed to sock_zerocopy_put_abort. This function accesses it only when uarg is set, but smatch cannot infer this. Make this dependency explicit. Fixes: 52900d22288e ("udp: