Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI

2017-08-31 Thread Benjamin Herrenschmidt
On Thu, 2017-08-31 at 08:24 -0700, Vernon Mauery wrote: > +int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid) > > +{ > > + return -ENOTTY; > > +} > > +int ncsi_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid) > > +{ > > + return -ENOTTY; > > +} > >

Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI

2017-08-31 Thread Vernon Mauery
On 31-Aug-2017 01:38 PM, Samuel Mendoza-Jonas wrote: > Patch "net/ncsi: Configure VLAN tag filter" defined two new callback > functions in include/net/ncsi.h, but neglected the !CONFIG_NET_NCSI > case. This can cause a build error if these are referenced elsewhere > without NCSI enabled, for

Re: [PATCH net-next] net/ncsi: Define {add,kill}_vid callbacks for !CONFIG_NET_NCSI

2017-08-30 Thread Florian Fainelli
On August 30, 2017 8:38:46 PM PDT, Samuel Mendoza-Jonas wrote: >Patch "net/ncsi: Configure VLAN tag filter" defined two new callback >functions in include/net/ncsi.h, but neglected the !CONFIG_NET_NCSI >case. This can cause a build error if these are referenced elsewhere

[PATCH net-next] net/ncsi: Define {add,kill}_vid callbacks for !CONFIG_NET_NCSI

2017-08-30 Thread Samuel Mendoza-Jonas
Patch "net/ncsi: Configure VLAN tag filter" defined two new callback functions in include/net/ncsi.h, but neglected the !CONFIG_NET_NCSI case. This can cause a build error if these are referenced elsewhere without NCSI enabled, for example in ftgmac100: >>> ERROR: "ncsi_vlan_rx_kill_vid"