RE: [PATCH net-next] net: core: change bool members of struct net_device to bitfield members

2018-10-09 Thread David Laight
From: Heiner Kallweit > Sent: 08 October 2018 21:01 > > bool is good as parameter type or function return type, but if used > for struct members it consumes more memory than needed. Actually it can generate extra code when used as a parameter or return type - but DM doesn't seem to worry about th

Re: [PATCH net-next] net: core: change bool members of struct net_device to bitfield members

2018-10-08 Thread Heiner Kallweit
On 08.10.2018 23:20, Stephen Hemminger wrote: > On Mon, 8 Oct 2018 22:00:51 +0200 > Heiner Kallweit wrote: > >> * >> + * @uc_promisc:Counter that indicates promiscuous mode >> + * has been enabled due to the need to listen to >> + * additional unicast addr

Re: [PATCH net-next] net: core: change bool members of struct net_device to bitfield members

2018-10-08 Thread Stephen Hemminger
On Mon, 8 Oct 2018 22:00:51 +0200 Heiner Kallweit wrote: > * > + * @uc_promisc:Counter that indicates promiscuous mode > + * has been enabled due to the need to listen to > + * additional unicast addresses in a device that > + * does n

Re: [PATCH net-next] net: core: change bool members of struct net_device to bitfield members

2018-10-08 Thread Heiner Kallweit
On 08.10.2018 22:07, Randy Dunlap wrote: > On 10/8/18 1:00 PM, Heiner Kallweit wrote: >> bool is good as parameter type or function return type, but if used >> for struct members it consumes more memory than needed. >> Changing the bool members of struct net_device to bitfield members >> allows to

Re: [PATCH net-next] net: core: change bool members of struct net_device to bitfield members

2018-10-08 Thread Randy Dunlap
On 10/8/18 1:00 PM, Heiner Kallweit wrote: > bool is good as parameter type or function return type, but if used > for struct members it consumes more memory than needed. > Changing the bool members of struct net_device to bitfield members > allows to decrease the memory footprint of this struct. >

[PATCH net-next] net: core: change bool members of struct net_device to bitfield members

2018-10-08 Thread Heiner Kallweit
bool is good as parameter type or function return type, but if used for struct members it consumes more memory than needed. Changing the bool members of struct net_device to bitfield members allows to decrease the memory footprint of this struct. Signed-off-by: Heiner Kallweit --- include/linux/