Re: [PATCH net-next] net: ipv6: Generate random IID for addresses on RAWIP devices

2018-06-08 Thread Subash Abhinov Kasiviswanathan
Actually, I think this is fine. RFC 7136 clarified this, and says: == Thus, we can conclude that the value of the "u" bit in IIDs has no particular meaning. In the case of an IID created from a MAC address according to RFC 4291, its value is determined by the MAC address, but t

Re: [PATCH net-next] net: ipv6: Generate random IID for addresses on RAWIP devices

2018-06-07 Thread Lorenzo Colitti
On Mon, Jun 4, 2018 at 8:51 AM 吉藤英明 wrote: > > > + if (ipv6_get_lladdr(dev, &lladdr, IFA_F_TENTATIVE)) > > + get_random_bytes(eui, 8); > > Please be aware of I/G bit and G/L bit. Actually, I think this is fine. RFC 7136 clarified this, and says: == Thus, we can conclu

Re: [PATCH net-next] net: ipv6: Generate random IID for addresses on RAWIP devices

2018-06-04 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Sun, 3 Jun 2018 15:54:34 -0600 > RAWIP devices such as rmnet do not have a hardware address and > instead require the kernel to generate a random IID for the > temporary addresses. For permanent addresses, the device IID is > used along with prefix rece

Re: [PATCH net-next] net: ipv6: Generate random IID for addresses on RAWIP devices

2018-06-03 Thread 吉藤英明
Hello, 2018-06-04 6:54 GMT+09:00 Subash Abhinov Kasiviswanathan : > RAWIP devices such as rmnet do not have a hardware address and > instead require the kernel to generate a random IID for the > temporary addresses. For permanent addresses, the device IID is > used along with prefix received. > >

[PATCH net-next] net: ipv6: Generate random IID for addresses on RAWIP devices

2018-06-03 Thread Subash Abhinov Kasiviswanathan
RAWIP devices such as rmnet do not have a hardware address and instead require the kernel to generate a random IID for the temporary addresses. For permanent addresses, the device IID is used along with prefix received. Signed-off-by: Subash Abhinov Kasiviswanathan --- net/ipv6/addrconf.c | 17 +