[PATCH net-next] net: lantiq: Fix return value check in xrx200_probe()

2018-09-14 Thread Wei Yongjun
In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver") Signed-off-by: Wei Yongjun --- drivers/net/eth

Re: [PATCH net-next] net: lantiq: Fix return value check in xrx200_probe()

2018-09-15 Thread Hauke Mehrtens
On 09/15/2018 03:33 AM, Wei Yongjun wrote: > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driv

Re: [PATCH net-next] net: lantiq: Fix return value check in xrx200_probe()

2018-09-17 Thread David Miller
From: Wei Yongjun Date: Sat, 15 Sep 2018 01:33:50 + > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX20