RE: [PATCH net-next] net: sch: prio: Set bands to default on delete instead of noop

2018-04-29 Thread Nogah Frankel
> > When a band is created, it is set to the default qdisc, which is > > "invisible" pfifo. > > However, if a band is set to a qdisc that is later being deleted, it will > > be set to noop qdisc. This can cause a packet loss, while there is no clear > > user indication for it. ("invisible" qdisc

Re: [PATCH net-next] net: sch: prio: Set bands to default on delete instead of noop

2018-04-27 Thread David Miller
From: Nogah Frankel Date: Thu, 26 Apr 2018 16:32:36 +0300 > When a band is created, it is set to the default qdisc, which is > "invisible" pfifo. > However, if a band is set to a qdisc that is later being deleted, it will > be set to noop qdisc. This can cause a packet loss,

Re: [PATCH net-next] net: sch: prio: Set bands to default on delete instead of noop

2018-04-27 Thread Cong Wang
On Thu, Apr 26, 2018 at 6:32 AM, Nogah Frankel wrote: > When a band is created, it is set to the default qdisc, which is > "invisible" pfifo. Isn't TCA_DUMP_INVISIBLE for dumping this invisible qdisc? > However, if a band is set to a qdisc that is later being deleted, it

[PATCH net-next] net: sch: prio: Set bands to default on delete instead of noop

2018-04-26 Thread Nogah Frankel
When a band is created, it is set to the default qdisc, which is "invisible" pfifo. However, if a band is set to a qdisc that is later being deleted, it will be set to noop qdisc. This can cause a packet loss, while there is no clear user indication for it. ("invisible" qdisc are not being shown