Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-16 Thread Jamal Hadi Salim
Sorry I dropped this. On 14/05/18 10:08 AM, Michel Machado wrote: On 09/05/18 01:37 PM, Michel Machado wrote: A simplified description of what DSprio is meant to do is as follows: when a link is overloaded at a router, DSprio makes this router drop the packets of lower priority. Makes

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-14 Thread Michel Machado
On 09/05/18 01:37 PM, Michel Machado wrote: On 05/09/2018 10:43 AM, Jamal Hadi Salim wrote: On 08/05/18 10:27 PM, Cong Wang wrote: On Tue, May 8, 2018 at 6:29 AM, Jamal Hadi Salim wrote: I like the suggestion of extending skbmod to mark skbprio based on ds. Given that

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-12 Thread Jamal Hadi Salim
Sorry for the latency.. On 09/05/18 01:37 PM, Michel Machado wrote: On 05/09/2018 10:43 AM, Jamal Hadi Salim wrote: On 08/05/18 10:27 PM, Cong Wang wrote: On Tue, May 8, 2018 at 6:29 AM, Jamal Hadi Salim wrote: I like the suggestion of extending skbmod to mark skbprio

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-10 Thread Michel Machado
On 05/10/2018 01:38 PM, Cong Wang wrote: On Wed, May 9, 2018 at 7:09 AM, Michel Machado wrote: On 05/08/2018 10:24 PM, Cong Wang wrote: On Tue, May 8, 2018 at 5:59 AM, Michel Machado wrote: Overall it looks good to me, just one thing below:

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-10 Thread Cong Wang
On Wed, May 9, 2018 at 7:09 AM, Michel Machado wrote: > On 05/08/2018 10:24 PM, Cong Wang wrote: >> >> On Tue, May 8, 2018 at 5:59 AM, Michel Machado >> wrote: > > Overall it looks good to me, just one thing below: > >> +struct

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-09 Thread Michel Machado
On 05/09/2018 10:43 AM, Jamal Hadi Salim wrote: On 08/05/18 10:27 PM, Cong Wang wrote: On Tue, May 8, 2018 at 6:29 AM, Jamal Hadi Salim wrote: Have you considered using skb->prio instead of peeking into the packet header. Also have you looked at the dsmark qdisc? dsmark

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-09 Thread Jamal Hadi Salim
On 08/05/18 10:27 PM, Cong Wang wrote: On Tue, May 8, 2018 at 6:29 AM, Jamal Hadi Salim wrote: Have you considered using skb->prio instead of peeking into the packet header. Also have you looked at the dsmark qdisc? dsmark modifies ds fields, while this one just maps ds

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-09 Thread Michel Machado
On 05/08/2018 10:24 PM, Cong Wang wrote: On Tue, May 8, 2018 at 5:59 AM, Michel Machado wrote: Overall it looks good to me, just one thing below: +struct Qdisc_ops gkprio_qdisc_ops __read_mostly = { + .id = "gkprio", + .priv_size =

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Cong Wang
On Tue, May 8, 2018 at 6:29 AM, Jamal Hadi Salim wrote: > Have you considered using skb->prio instead of peeking into the packet > header. > Also have you looked at the dsmark qdisc? > dsmark modifies ds fields, while this one just maps ds fields into different queues.

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Cong Wang
On Tue, May 8, 2018 at 5:59 AM, Michel Machado wrote: >>> Overall it looks good to me, just one thing below: >>> +struct Qdisc_ops gkprio_qdisc_ops __read_mostly = { + .id = "gkprio", + .priv_size = sizeof(struct

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Michel Machado
On 05/08/2018 09:29 AM, Jamal Hadi Salim wrote: On 08/05/18 08:59 AM, Michel Machado wrote: Overall it looks good to me, just one thing below: +struct Qdisc_ops gkprio_qdisc_ops __read_mostly = { +   .id =   "gkprio", +   .priv_size  =   sizeof(struct

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Michel Machado
Overall it looks good to me, just one thing below: +struct Qdisc_ops gkprio_qdisc_ops __read_mostly = { + .id = "gkprio", + .priv_size = sizeof(struct gkprio_sched_data), + .enqueue= gkprio_enqueue, + .dequeue=

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Jamal Hadi Salim
On 08/05/18 08:59 AM, Michel Machado wrote: Overall it looks good to me, just one thing below: +struct Qdisc_ops gkprio_qdisc_ops __read_mostly = { +   .id =   "gkprio", +   .priv_size  =   sizeof(struct gkprio_sched_data), +   .enqueue    =  

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Nishanth Devarajan
On Mon, May 07, 2018 at 10:24:51PM -0700, Cong Wang wrote: > On Mon, May 7, 2018 at 2:36 AM, Nishanth Devarajan wrote: > > net/sched: add gkprio scheduler > > > > Gkprio (Gatekeeper Priority Queue) is a queueing discipline that prioritizes > > IPv4 and IPv6 packets accordingly

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-07 Thread Cong Wang
On Mon, May 7, 2018 at 2:36 AM, Nishanth Devarajan wrote: > net/sched: add gkprio scheduler > > Gkprio (Gatekeeper Priority Queue) is a queueing discipline that prioritizes > IPv4 and IPv6 packets accordingly to their DSCP field. Although Gkprio can be > employed in any QoS

[PATCH net-next] net:sched: add gkprio scheduler

2018-05-07 Thread Nishanth Devarajan
net/sched: add gkprio scheduler Gkprio (Gatekeeper Priority Queue) is a queueing discipline that prioritizes IPv4 and IPv6 packets accordingly to their DSCP field. Although Gkprio can be employed in any QoS scenario in which a higher DSCP field means a higher priority packet, Gkprio was concieved