Re: [RESEND PATCH net-next] r8169: add module param for control of ASPM disable.

2018-02-14 Thread Andrew Lunn
On Wed, Feb 14, 2018 at 12:22:02PM -0500, David Miller wrote: > From: Andrew Lunn > Date: Wed, 14 Feb 2018 14:40:40 +0100 > > > linux/drivers$ grep -ir aspm * | grep MODULE_ > > gpu/drm/amd/amdgpu/amdgpu_drv.c:MODULE_PARM_DESC(aspm, "ASPM support (1 = > > enable, 0 = disable, -1

Re: [RESEND PATCH net-next] r8169: add module param for control of ASPM disable.

2018-02-14 Thread David Miller
From: Andrew Lunn Date: Wed, 14 Feb 2018 14:40:40 +0100 > linux/drivers$ grep -ir aspm * | grep MODULE_ > gpu/drm/amd/amdgpu/amdgpu_drv.c:MODULE_PARM_DESC(aspm, "ASPM support (1 = > enable, 0 = disable, -1 = auto)"); > gpu/drm/radeon/radeon_drv.c:MODULE_PARM_DESC(aspm, "ASPM

Re: [RESEND PATCH net-next] r8169: add module param for control of ASPM disable.

2018-02-14 Thread Andrew Lunn
On Wed, Feb 14, 2018 at 05:02:45PM +0800, Chunhao Lin wrote: > The patch is from Todd Broch . > ASPM has been disabled in this driver by default as its been > implicated in stability issues on at least one platform. This CL adds > a module parameter to allow

[RESEND PATCH net-next] r8169: add module param for control of ASPM disable.

2018-02-14 Thread Chunhao Lin
The patch is from Todd Broch . ASPM has been disabled in this driver by default as its been implicated in stability issues on at least one platform. This CL adds a module parameter to allow control of ASPM disable. The default value is to

RE: [PATCH net-next] r8169: add module param for control of ASPM disable

2018-02-02 Thread Hau
> -Original Message- > From: Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Friday, February 2, 2018 7:27 AM > To: Hau <h...@realtek.com> > Cc: netdev@vger.kernel.org; nic_swsd <nic_s...@realtek.com>; linux- > ker...@vger.kernel.org > Subject: Re: [

Re: [PATCH net-next] r8169: add module param for control of ASPM disable

2018-02-01 Thread Francois Romieu
net-next is closed anyway. -- Ueimor

Re: [PATCH net-next] r8169: add module param for control of ASPM disable

2018-02-01 Thread Francois Romieu
Chunhao Lin : [...] > @@ -5878,6 +5881,20 @@ static void rtl_pcie_state_l2l3_enable(struct > rtl8169_private *tp, bool enable) > RTL_W8(Config3, data); > } > > +static void rtl_hw_internal_aspm_clkreq_enable(struct rtl8169_private *tp, > +

[PATCH net-next] r8169: add module param for control of ASPM disable

2018-02-01 Thread Chunhao Lin
The patch is from Todd Broch . ASPM has been disabled in this driver by default as its been implicated in stability issues on at least one platform. This CL adds a module parameter to allow control of ASPM disable. The default value is to