Re: [PATCH net-next] r8169: improve rtl8169_start_xmit

2020-11-16 Thread Jakub Kicinski
On Sat, 14 Nov 2020 21:49:53 +0100 Heiner Kallweit wrote: > Improve the following in rtl8169_start_xmit: > - tp->cur_tx can be accessed in parallel by rtl_tx(), therefore > annotate the race by using WRITE_ONCE > - avoid checking stop_queue a second time by moving the doorbell check > - netif_sto

[PATCH net-next] r8169: improve rtl8169_start_xmit

2020-11-14 Thread Heiner Kallweit
Improve the following in rtl8169_start_xmit: - tp->cur_tx can be accessed in parallel by rtl_tx(), therefore annotate the race by using WRITE_ONCE - avoid checking stop_queue a second time by moving the doorbell check - netif_stop_queue() uses atomic operation set_bit() that includes a full mem