Re: [PATCH net-next] r8169: perform reset synchronously in __rtl8169_resume

2018-05-22 Thread Francois Romieu
David Miller : > From: Heiner Kallweit > Date: Mon, 21 May 2018 19:01:19 +0200 > > > The driver uses pm_runtime_get_sync() in few places and relies on the > > device being fully runtime-resumed after this call. So far however > > the runtime resume

Re: [PATCH net-next] r8169: perform reset synchronously in __rtl8169_resume

2018-05-22 Thread David Miller
From: Heiner Kallweit Date: Mon, 21 May 2018 19:01:19 +0200 > The driver uses pm_runtime_get_sync() in few places and relies on the > device being fully runtime-resumed after this call. So far however > the runtime resume callback triggers an asynchronous reset. > Avoid

Re: [PATCH net-next] r8169: perform reset synchronously in __rtl8169_resume

2018-05-21 Thread Heiner Kallweit
Am 21.05.2018 um 23:24 schrieb Francois Romieu: > Heiner Kallweit : > [...] >> diff --git a/drivers/net/ethernet/realtek/r8169.c >> b/drivers/net/ethernet/realtek/r8169.c >> index 75dfac024..1eb4f625a 100644 >> --- a/drivers/net/ethernet/realtek/r8169.c >> +++

Re: [PATCH net-next] r8169: perform reset synchronously in __rtl8169_resume

2018-05-21 Thread Francois Romieu
Heiner Kallweit : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 75dfac024..1eb4f625a 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -7327,9 +7327,9 @@ static

[PATCH net-next] r8169: perform reset synchronously in __rtl8169_resume

2018-05-21 Thread Heiner Kallweit
The driver uses pm_runtime_get_sync() in few places and relies on the device being fully runtime-resumed after this call. So far however the runtime resume callback triggers an asynchronous reset. Avoid this and perform the reset synchronously. Signed-off-by: Heiner Kallweit