Re: [PATCH net-next] rtnetlink: add support for protodown reason

2020-07-30 Thread Roopa Prabhu
On 7/30/20 4:38 PM, David Miller wrote: From: Roopa Prabhu Date: Mon, 27 Jul 2020 12:21:17 -0700 +/** + * dev_get_proto_down_reason - returns protodown reason + * + * @dev: device + */ +u32 dev_get_proto_down_reason(const struct net_device *dev) +{ + return dev->proto_down_reason; +}

Re: [PATCH net-next] rtnetlink: add support for protodown reason

2020-07-30 Thread David Miller
From: Roopa Prabhu Date: Mon, 27 Jul 2020 12:21:17 -0700 > +/** > + * dev_get_proto_down_reason - returns protodown reason > + * > + * @dev: device > + */ > +u32 dev_get_proto_down_reason(const struct net_device *dev) > +{ > + return dev->proto_down_reason; > +} > +EXPORT_SYMBOL(dev_get_p

Re: [PATCH net-next] rtnetlink: add support for protodown reason

2020-07-27 Thread Roopa Prabhu
On 7/27/20 1:47 PM, Stephen Hemminger wrote: External email: Use caution opening links or attachments On Mon, 27 Jul 2020 12:21:17 -0700 Roopa Prabhu wrote: -+ nla_total_size(1) /* IFLA_PROTO_DOWN */ ++ rtnl_proto_down_size(dev) /* proto down */ Changing the size

Re: [PATCH net-next] rtnetlink: add support for protodown reason

2020-07-27 Thread Stephen Hemminger
On Mon, 27 Jul 2020 12:21:17 -0700 Roopa Prabhu wrote: > -+ nla_total_size(1) /* IFLA_PROTO_DOWN */ > ++ rtnl_proto_down_size(dev) /* proto down */ Changing the size of a netlink field is an ABI change in the kernel. This has the potential to break existing programs. W

[PATCH net-next] rtnetlink: add support for protodown reason

2020-07-27 Thread Roopa Prabhu
From: Roopa Prabhu netdev protodown is a mechanism that allows protocols to hold an interface down. It was initially introduced in the kernel to hold links down by a multihoming protocol. There was also an attempt to introduce protodown reason at the time but was rejected. protodown and protodown