[PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Wei Yongjun
Return error code -EINVAL in the address len check error handling case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' in the for loop. Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for sendmsg") Signed-off-by: Wei Yongjun --- net/sctp/socket.c | 8 +++

Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Xin Long
On Mon, Mar 12, 2018 at 8:16 PM, Wei Yongjun wrote: > Return error code -EINVAL in the address len check error handling > case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' > in the for loop. > > Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for > send

Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread David Miller
From: Wei Yongjun Date: Mon, 12 Mar 2018 12:16:04 + > Return error code -EINVAL in the address len check error handling > case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' > in the for loop. > > Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for

Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Neil Horman
On Mon, Mar 12, 2018 at 12:16:04PM +, Wei Yongjun wrote: > Return error code -EINVAL in the address len check error handling > case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' > in the for loop. > > Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information fo

Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Marcelo Ricardo Leitner
On Mon, Mar 12, 2018 at 09:38:53PM +0800, Xin Long wrote: > On Mon, Mar 12, 2018 at 8:16 PM, Wei Yongjun wrote: ... > Btw, the 'err' initialization can also be removed in your patch. I second this.

Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Xin Long
On Mon, Mar 12, 2018 at 11:19 PM, David Miller wrote: > From: Wei Yongjun > Date: Mon, 12 Mar 2018 12:16:04 + > >> Return error code -EINVAL in the address len check error handling >> case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' >> in the for loop. >> >> Fixes: 2c0dbaa