Re: [PATCH net-next] tcp: fix TCP_SYNCNT flakes

2017-05-24 Thread David Miller
From: Eric Dumazet Date: Tue, 23 May 2017 12:38:35 -0700 > From: Eric Dumazet > > After the mentioned commit, some of our packetdrill tests became flaky. > > TCP_SYNCNT socket option can limit the number of SYN retransmits. > > retransmits_timed_out() has to compare times computations based o

Re: [PATCH net-next] tcp: fix TCP_SYNCNT flakes

2017-05-23 Thread Soheil Hassas Yeganeh
On Tue, May 23, 2017 at 3:38 PM, Eric Dumazet wrote: > From: Eric Dumazet > > After the mentioned commit, some of our packetdrill tests became flaky. > > TCP_SYNCNT socket option can limit the number of SYN retransmits. > > retransmits_timed_out() has to compare times computations based on > loca

[PATCH net-next] tcp: fix TCP_SYNCNT flakes

2017-05-23 Thread Eric Dumazet
From: Eric Dumazet After the mentioned commit, some of our packetdrill tests became flaky. TCP_SYNCNT socket option can limit the number of SYN retransmits. retransmits_timed_out() has to compare times computations based on local_clock() while timers are based on jiffies. With NTP adjustments a