Re: [PATCH net-next] udp: handle gro_receive only when necessary

2017-12-19 Thread Paolo Abeni
On Tue, 2017-12-19 at 19:01 +0800, zhangliping wrote: > At 2017-12-18 22:45:30, "Paolo Abeni" wrote: > > Understood, thanks. Still the time spent in 'udp4_lib_lookup2' looks > > quite different/higher than what I observe in my tests. Are you using > > x86_64? if not, do you see many cache misses i

Re: [PATCH net-next] udp: handle gro_receive only when necessary

2017-12-19 Thread zhangliping
Hi, At 2017-12-18 22:45:30, "Paolo Abeni" wrote: >Understood, thanks. Still the time spent in 'udp4_lib_lookup2' looks >quite different/higher than what I observe in my tests. Are you using >x86_64? if not, do you see many cache misses in udp4_lib_lookup2? Yes, x86_64. Here is the host's lscpu o

Re: [PATCH net-next] udp: handle gro_receive only when necessary

2017-12-18 Thread Paolo Abeni
On Mon, 2017-12-18 at 20:09 +0800, zhangliping wrote: > My test case is very simple, two VMs were connected via ovs + dpdk. > Inside VM, rps is enabled. Then one VM runs "iperf -s -u &", another > VM runs "iperf -c 1.1.1.2 -P 12 -u -b 10Gbps -l 40 -t 36000". Understood, thanks. Still the time spen

Re: [PATCH net-next] udp: handle gro_receive only when necessary

2017-12-18 Thread zhangliping
Hi, At 2017-12-18 18:26:28, "Paolo Abeni" wrote: >Hi, > >On Mon, 2017-12-18 at 12:11 +0800, zhangliping wrote: >> From: zhangliping >> >> Under our udp pressure performance test, after gro is disabled, rx rate >> will be improved from ~2500kpps to ~2800kpps. We can find some difference >> from

Re: [PATCH net-next] udp: handle gro_receive only when necessary

2017-12-18 Thread Paolo Abeni
Hi, On Mon, 2017-12-18 at 12:11 +0800, zhangliping wrote: > From: zhangliping > > Under our udp pressure performance test, after gro is disabled, rx rate > will be improved from ~2500kpps to ~2800kpps. We can find some difference > from perf report: > 1. gro is enabled: > 24.23% [kernel]

[PATCH net-next] udp: handle gro_receive only when necessary

2017-12-17 Thread zhangliping
From: zhangliping Under our udp pressure performance test, after gro is disabled, rx rate will be improved from ~2500kpps to ~2800kpps. We can find some difference from perf report: 1. gro is enabled: 24.23% [kernel] [k] udp4_lib_lookup2 5.42% [kernel] [k] __memcpy 3.87%