Re: [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int.

2017-04-09 Thread Alexey Dobriyan
> struct skb_shared_info { > + unsigned short _unused; > unsigned char nr_frags; This makes _all_ fields to be accessed with offset, but if you move padding down, at least ->nr_frags will enjoy clean and simple [R64] addressing. On allyesconfig-ish kernel: before: +542 =

Re: [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int.

2017-04-08 Thread David Miller
From: Eric Dumazet Date: Sat, 08 Apr 2017 11:55:32 -0700 > On Sat, 2017-04-08 at 20:36 +0200, Steffen Klassert wrote: >> All available gso_type flags are currently in use, so >> extend gso_type from 'unsigned short' to 'unsigned int' >> to be able to add further flags. >>

Re: [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int.

2017-04-08 Thread Eric Dumazet
On Sat, 2017-04-08 at 20:36 +0200, Steffen Klassert wrote: > All available gso_type flags are currently in use, so > extend gso_type from 'unsigned short' to 'unsigned int' > to be able to add further flags. > > We reorder the struct skb_shared_info to use > two bytes of the four byte hole before

[PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int.

2017-04-08 Thread Steffen Klassert
All available gso_type flags are currently in use, so extend gso_type from 'unsigned short' to 'unsigned int' to be able to add further flags. We reorder the struct skb_shared_info to use two bytes of the four byte hole before dataref. All fields before dataref are cleared, i.e. four bytes more

[PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int

2017-04-08 Thread Steffen Klassert
We need a GSO type for IPsec ESP to be able to integrate the IPsec hardware offloading infrastructure. Unfortunately, all gso_type flags are currently in use. This change extends gso_type from 'unsigned short' to 'unsigned int'. Changes from v1: - Place the remaining two byte hole in front,