Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-27 Thread Jiri Pirko
Tue, Sep 26, 2017 at 04:50:10PM CEST, pab...@redhat.com wrote: >On Tue, 2017-09-26 at 17:17 +0300, Or Gerlitz wrote: >> On Tue, Sep 26, 2017 at 3:51 PM, Jiri Benc wrote: >> > On Tue, 26 Sep 2017 15:41:37 +0300, Or Gerlitz wrote: >> > > Please note that the way the rule is being

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-27 Thread Simon Horman
On Tue, Sep 26, 2017 at 09:29:03PM -0700, David Miller wrote: > From: Simon Horman > Date: Mon, 25 Sep 2017 12:23:34 +0200 > > > From: Simon Horman > > > > John says: > > > > This patch set allows offloading of TC flower match and set

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-26 Thread David Miller
From: Simon Horman Date: Mon, 25 Sep 2017 12:23:34 +0200 > From: Simon Horman > > John says: > > This patch set allows offloading of TC flower match and set tunnel fields > to the NFP. The initial focus is on VXLAN traffic. Due to the

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-26 Thread Paolo Abeni
On Tue, 2017-09-26 at 17:17 +0300, Or Gerlitz wrote: > On Tue, Sep 26, 2017 at 3:51 PM, Jiri Benc wrote: > > On Tue, 26 Sep 2017 15:41:37 +0300, Or Gerlitz wrote: > > > Please note that the way the rule is being set to the HW driver is by > > > delegation > > > done in flower,

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-26 Thread Jiri Benc
On Tue, 26 Sep 2017 17:17:02 +0300, Or Gerlitz wrote: > maybe before/instead you call it a bug, But it is a bug. When offloaded, the rules must not behave differently. That's the fundamental thing about offloading. Here, the rules behave differently when offloaded and when not. That's a bug. >

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-26 Thread Or Gerlitz
On Tue, Sep 26, 2017 at 3:51 PM, Jiri Benc wrote: > On Tue, 26 Sep 2017 15:41:37 +0300, Or Gerlitz wrote: >> Please note that the way the rule is being set to the HW driver is by >> delegation >> done in flower, see these commits (specifically "Add offload support >> using

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-26 Thread Jiri Benc
On Tue, 26 Sep 2017 15:41:37 +0300, Or Gerlitz wrote: > Please note that the way the rule is being set to the HW driver is by > delegation > done in flower, see these commits (specifically "Add offload support > using egress Hardware device") It's very well possible the bug is somewhere in

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-26 Thread Or Gerlitz
On Tue, Sep 26, 2017 at 1:15 PM, Jiri Benc wrote: > On Mon, 25 Sep 2017 19:04:53 +0200, Simon Horman wrote: >> The MAC addresses are extracted from the netdevs already loaded in the >> kernel and are monitored for any changes. The IP addresses are slightly >> different in that

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-26 Thread Jiri Benc
On Mon, 25 Sep 2017 19:04:53 +0200, Simon Horman wrote: > The MAC addresses are extracted from the netdevs already loaded in the > kernel and are monitored for any changes. The IP addresses are slightly > different in that they are extracted from the rules themselves. We make the > assumption

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Simon Horman
On Mon, Sep 25, 2017 at 06:25:03PM +0300, Or Gerlitz wrote: > On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman > wrote: > > From: Simon Horman > > > > John says: > > > > This patch set allows offloading of TC flower match and set tunnel fields

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Or Gerlitz
On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman wrote: > From: Simon Horman > > John says: > > This patch set allows offloading of TC flower match and set tunnel fields > to the NFP. The initial focus is on VXLAN traffic. Due to the current >

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Jakub Kicinski
On Mon, 25 Sep 2017 12:23:34 +0200, Simon Horman wrote: > From: Simon Horman > > John says: > > This patch set allows offloading of TC flower match and set tunnel fields > to the NFP. The initial focus is on VXLAN traffic. Due to the current > state of the NFP

[PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Simon Horman
From: Simon Horman John says: This patch set allows offloading of TC flower match and set tunnel fields to the NFP. The initial focus is on VXLAN traffic. Due to the current state of the NFP firmware, only VXLAN traffic on well known port 4789 is handled. The match