Re: [PATCH net-next 0/8] add TX timestamping via cmsg

2016-04-03 Thread Willem de Bruijn
>> This does not yet solve the append issue that your MSG_EOR patch >> addresses, of course. > Yes. I have been thinking about both approaches. > >> >> The straightforward jump to new_segment that I proposed as >> simplification is more properly a "start-of-record" than >> "end-of-record" signal.

Re: [PATCH net-next 0/8] add TX timestamping via cmsg

2016-03-31 Thread Martin KaFai Lau
On Wed, Mar 30, 2016 at 11:50:31PM -0400, Willem de Bruijn wrote: > >> Nice patches! > > This does not yet solve the append issue that your MSG_EOR patch > addresses, of course. Yes. I have been thinking about both approaches. > > The straightforward jump to new_segment that I proposed as >

Re: [PATCH net-next 0/8] add TX timestamping via cmsg

2016-03-30 Thread Willem de Bruijn
>> Nice patches! This does not yet solve the append issue that your MSG_EOR patch addresses, of course. The straightforward jump to new_segment that I proposed as simplification is more properly a "start-of-record" than "end-of-record" signal. It is probably preferable to indeed be able to pass

Re: [PATCH net-next 0/8] add TX timestamping via cmsg

2016-03-30 Thread Soheil Hassas Yeganeh
On Wed, Mar 30, 2016 at 8:38 PM, Martin KaFai Lau wrote: > On Wed, Mar 30, 2016 at 06:37:20PM -0400, Soheil Hassas Yeganeh wrote: >> I will follow up with another patch to enable timestamping for >> active TFO (client-side TCP Fast Open) and also setting packet >> mark via cmsgs. >

Re: [PATCH net-next 0/8] add TX timestamping via cmsg

2016-03-30 Thread Martin KaFai Lau
On Wed, Mar 30, 2016 at 06:37:20PM -0400, Soheil Hassas Yeganeh wrote: > I will follow up with another patch to enable timestamping for > active TFO (client-side TCP Fast Open) and also setting packet > mark via cmsgs. Can you share more details on what 'setting packet mark' does? Nice patches!

[PATCH net-next 0/8] add TX timestamping via cmsg

2016-03-30 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh This patch series aim at enabling TX timestamping via cmsg. Currently, to occasionally sample TX timestamping on a socket, applications need to call setsockopt twice: first for enabling timestamps and then for disabling them. This is an unnecessary