Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Samudrala, Sridhar
On 11/18/2020 5:17 PM, David Ahern wrote: On 11/18/20 5:41 PM, Jacob Keller wrote: On 11/18/2020 11:22 AM, Parav Pandit wrote: From: David Ahern Sent: Wednesday, November 18, 2020 11:33 PM With Connectx-4 Lx for example the netdev can have at most 63 queues leaving 96 cpu servers a b

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread David Ahern
On 11/18/20 5:41 PM, Jacob Keller wrote: > > > On 11/18/2020 11:22 AM, Parav Pandit wrote: >> >> >>> From: David Ahern >>> Sent: Wednesday, November 18, 2020 11:33 PM >>> >>> >>> With Connectx-4 Lx for example the netdev can have at most 63 queues >>> leaving 96 cpu servers a bit short - as an e

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Jacob Keller
On 11/18/2020 9:02 AM, Parav Pandit wrote: > >> From: David Ahern >> Sent: Wednesday, November 18, 2020 9:51 PM >> >> On 11/12/20 12:24 PM, Parav Pandit wrote: >>> Extended devlink interface for the user to add and delete port. >>> Extend devlink to connect user requests to driver to add/delet

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Jacob Keller
On 11/18/2020 11:22 AM, Parav Pandit wrote: > > >> From: David Ahern >> Sent: Wednesday, November 18, 2020 11:33 PM >> >> >> With Connectx-4 Lx for example the netdev can have at most 63 queues >> leaving 96 cpu servers a bit short - as an example of the limited number of >> queues that a nic

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Jason Gunthorpe
On Wed, Nov 18, 2020 at 12:36:26PM -0700, David Ahern wrote: > On 11/18/20 11:38 AM, Jason Gunthorpe wrote: > > On Wed, Nov 18, 2020 at 11:03:24AM -0700, David Ahern wrote: > > > >> With Connectx-4 Lx for example the netdev can have at most 63 queues > > > > What netdev calls a queue is really a

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread David Ahern
On 11/18/20 11:38 AM, Jason Gunthorpe wrote: > On Wed, Nov 18, 2020 at 11:03:24AM -0700, David Ahern wrote: > >> With Connectx-4 Lx for example the netdev can have at most 63 queues > > What netdev calls a queue is really a "can the device deliver > interrupts and packets to a given per-CPU queue

RE: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Parav Pandit
> From: David Ahern > Sent: Wednesday, November 18, 2020 11:33 PM > > > With Connectx-4 Lx for example the netdev can have at most 63 queues > leaving 96 cpu servers a bit short - as an example of the limited number of > queues that a nic can handle (or currently exposes to the OS not sure whi

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Jason Gunthorpe
On Wed, Nov 18, 2020 at 11:03:24AM -0700, David Ahern wrote: > With Connectx-4 Lx for example the netdev can have at most 63 queues What netdev calls a queue is really a "can the device deliver interrupts and packets to a given per-CPU queue" and covers a whole spectrum of smaller limits like RSS

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread David Ahern
On 11/18/20 10:02 AM, Parav Pandit wrote: > >> From: David Ahern >> Sent: Wednesday, November 18, 2020 9:51 PM >> >> On 11/12/20 12:24 PM, Parav Pandit wrote: >>> Extended devlink interface for the user to add and delete port. >>> Extend devlink to connect user requests to driver to add/delete su

RE: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Parav Pandit
> From: David Ahern > Sent: Wednesday, November 18, 2020 9:51 PM > > On 11/12/20 12:24 PM, Parav Pandit wrote: > > Extended devlink interface for the user to add and delete port. > > Extend devlink to connect user requests to driver to add/delete such > > port in the device. > > > > When driver

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread David Ahern
On 11/12/20 12:24 PM, Parav Pandit wrote: > Extended devlink interface for the user to add and delete port. > Extend devlink to connect user requests to driver to add/delete > such port in the device. > > When driver routines are invoked, devlink instance lock is not held. > This enables driver to

[PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-12 Thread Parav Pandit
Extended devlink interface for the user to add and delete port. Extend devlink to connect user requests to driver to add/delete such port in the device. When driver routines are invoked, devlink instance lock is not held. This enables driver to perform several devlink objects registration, unregis