Re: [PATCH net-next 09/13] net: sched: extend tcf_block with rcu

2018-09-12 Thread Vlad Buslov
On Fri 07 Sep 2018 at 19:52, Cong Wang wrote: > On Thu, Sep 6, 2018 at 12:59 AM Vlad Buslov wrote: >> >> Extend tcf_block with rcu to allow safe deallocation when it is accessed >> concurrently. > > This sucks, please fold this patch into where you call rcu_read_lock() > on tcf block. > > This

Re: [PATCH net-next 09/13] net: sched: extend tcf_block with rcu

2018-09-07 Thread Cong Wang
On Thu, Sep 6, 2018 at 12:59 AM Vlad Buslov wrote: > > Extend tcf_block with rcu to allow safe deallocation when it is accessed > concurrently. This sucks, please fold this patch into where you call rcu_read_lock() on tcf block. This patch _alone_ is apparently not complete. This is not how we s

[PATCH net-next 09/13] net: sched: extend tcf_block with rcu

2018-09-06 Thread Vlad Buslov
Extend tcf_block with rcu to allow safe deallocation when it is accessed concurrently. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- include/net/sch_generic.h | 1 + net/sched/cls_api.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/net/sch_generi