Re: [PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread Gao Feng
Hi Eric, On Tue, Dec 6, 2016 at 2:53 PM, Eric Dumazet wrote: > On Tue, 2016-12-06 at 14:31 +0800, Gao Feng wrote: > >> Because I don't fully hold the ipvlan codes now, I am afraid of that >> there is someone which may get the port address when >> ipvlan_port_destroy. So

Re: [PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread Eric Dumazet
On Tue, 2016-12-06 at 14:31 +0800, Gao Feng wrote: > Because I don't fully hold the ipvlan codes now, I am afraid of that > there is someone which may get the port address when > ipvlan_port_destroy. So the original ipvlan_port_destroy uses the > kfree_rcu to avoid it. > > I am sure there is

Re: [PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread Gao Feng
Hi Eric, On Tue, Dec 6, 2016 at 2:25 PM, Eric Dumazet wrote: > On Tue, 2016-12-06 at 12:29 +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> There is no one which may reference the "port" in ipvlan_port_create >> when netdev_rx_handler_register

Re: [PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread Eric Dumazet
On Tue, 2016-12-06 at 12:29 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > There is no one which may reference the "port" in ipvlan_port_create > when netdev_rx_handler_register failed. So it could free it directly > with kfree instead of kfree_rcu. > > Signed-off-by: Gao

[PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread fgao
From: Gao Feng There is no one which may reference the "port" in ipvlan_port_create when netdev_rx_handler_register failed. So it could free it directly with kfree instead of kfree_rcu. Signed-off-by: Gao Feng --- drivers/net/ipvlan/ipvlan_main.c | 2 +- 1