Re: [PATCH net-next 1/1] net: fec: add netif status check before set mac address

2015-09-09 Thread Lucas Stach
Am Mittwoch, den 09.09.2015, 10:42 +0800 schrieb Fugang Duan: > There exist one issue by below case that case system hang: > ifconfig eth0 down > ifconfig eth0 hw ether 00:10:19:19:81:19 > > After eth0 down, all fec clocks are gated off. In the .fec_set_mac_address() > function, it will set new

RE: [PATCH net-next 1/1] net: fec: add netif status check before set mac address

2015-09-09 Thread Duan Andy
From: Lucas Stach <l.st...@pengutronix.de> Sent: Wednesday, September 09, 2015 5:14 PM > To: Duan Fugang-B38611 > Cc: da...@davemloft.net; netdev@vger.kernel.org; > bhutchi...@solarflare.com > Subject: Re: [PATCH net-next 1/1] net: fec: add netif status check before > se

Re: [PATCH net-next 1/1] net: fec: add netif status check before set mac address

2015-09-09 Thread David Miller
@solarflare.com >> Subject: Re: [PATCH net-next 1/1] net: fec: add netif status check before >> set mac address >> >> Le 09/08/15 19:42, Fugang Duan a écrit : >> > There exist one issue by below case that case system hang: >> > ifconfig eth0 down >>

[PATCH net-next 1/1] net: fec: add netif status check before set mac address

2015-09-08 Thread Fugang Duan
There exist one issue by below case that case system hang: ifconfig eth0 down ifconfig eth0 hw ether 00:10:19:19:81:19 After eth0 down, all fec clocks are gated off. In the .fec_set_mac_address() function, it will set new MAC address to registers, which causes system hang. So it needs to add

Re: [PATCH net-next 1/1] net: fec: add netif status check before set mac address

2015-09-08 Thread Florian Fainelli
Le 09/08/15 19:42, Fugang Duan a écrit : > There exist one issue by below case that case system hang: > ifconfig eth0 down > ifconfig eth0 hw ether 00:10:19:19:81:19 > > After eth0 down, all fec clocks are gated off. In the .fec_set_mac_address() > function, it will set new MAC address to

RE: [PATCH net-next 1/1] net: fec: add netif status check before set mac address

2015-09-08 Thread Duan Andy
From: Florian Fainelli <f.faine...@gmail.com> Sent: Wednesday, September 09, 2015 11:38 AM > To: Duan Fugang-B38611; da...@davemloft.net > Cc: netdev@vger.kernel.org; bhutchi...@solarflare.com > Subject: Re: [PATCH net-next 1/1] net: fec: add netif status check before > set mac