Re: [PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

2016-07-02 Thread Jamal Hadi Salim
On 16-07-02 10:16 AM, Jamal Hadi Salim wrote: On 16-07-02 10:07 AM, Nikolay Aleksandrov wrote: On 02/07/16 16:02, Jamal Hadi Salim wrote: On 16-07-02 09:49 AM, Nikolay Aleksandrov wrote: Also a minor suggestion - maybe err out on a zero mac address, otherwise the user might think the

Re: [PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

2016-07-02 Thread Jamal Hadi Salim
On 16-07-02 10:07 AM, Nikolay Aleksandrov wrote: On 02/07/16 16:02, Jamal Hadi Salim wrote: On 16-07-02 09:49 AM, Nikolay Aleksandrov wrote: Also a minor suggestion - maybe err out on a zero mac address, otherwise the user might think the operation was successful. Is a zero mac address

Re: [PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

2016-07-02 Thread Nikolay Aleksandrov
On 02/07/16 16:02, Jamal Hadi Salim wrote: > On 16-07-02 09:49 AM, Nikolay Aleksandrov wrote: >> On 02/07/16 15:26, Jamal Hadi Salim wrote: >>> From: Jamal Hadi Salim >>> >>> Often redirecting or mirroring requires that we set the MAC address >>> of the target device. While it

Re: [PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

2016-07-02 Thread Jamal Hadi Salim
On 16-07-02 09:49 AM, Nikolay Aleksandrov wrote: On 02/07/16 15:26, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Often redirecting or mirroring requires that we set the MAC address of the target device. While it is possible to pipe to a pedit action this obsoletes the

Re: [PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

2016-07-02 Thread Nikolay Aleksandrov
On 02/07/16 15:26, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Often redirecting or mirroring requires that we set the MAC address > of the target device. While it is possible to pipe to a pedit action > this obsoletes the need for that. This is justified feature

[PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

2016-07-02 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Often redirecting or mirroring requires that we set the MAC address of the target device. While it is possible to pipe to a pedit action this obsoletes the need for that. This is justified feature because the dst MAC addresses rewrite is such a common