Re: [PATCH net-next 1/2] flow_dissector: Cleanup control flow

2017-09-01 Thread Tom Herbert
On Fri, Sep 1, 2017 at 5:35 AM, Hannes Frederic Sowa wrote: > Tom Herbert writes: > >> __skb_flow_dissect is riddled with gotos that make discerning the flow, >> debugging, and extending the capability difficult. This patch >> reorganizes things

Re: [PATCH net-next 1/2] flow_dissector: Cleanup control flow

2017-09-01 Thread Hannes Frederic Sowa
Tom Herbert writes: > __skb_flow_dissect is riddled with gotos that make discerning the flow, > debugging, and extending the capability difficult. This patch > reorganizes things so that we only perform goto's after the two main > switch statements (no gotos within the cases

Re: [PATCH net-next 1/2] flow_dissector: Cleanup control flow

2017-09-01 Thread Simon Horman
Hi Tom, On Thu, Aug 31, 2017 at 03:22:38PM -0700, Tom Herbert wrote: > __skb_flow_dissect is riddled with gotos that make discerning the flow, > debugging, and extending the capability difficult. This patch > reorganizes things so that we only perform goto's after the two main > switch statements

[PATCH net-next 1/2] flow_dissector: Cleanup control flow

2017-08-31 Thread Tom Herbert
__skb_flow_dissect is riddled with gotos that make discerning the flow, debugging, and extending the capability difficult. This patch reorganizes things so that we only perform goto's after the two main switch statements (no gotos within the cases now). It also eliminates several goto labels so