Re: [PATCH net-next 1/2] mpls: packet stats

2016-07-28 Thread Roopa Prabhu
On 2/5/16, 11:27 AM, Robert Shearman wrote: > Having MPLS packet stats is useful for observing network operation and > for diagnosing network problems. In the absence of anything better, > use RFCs for MIBs defining MPLS stats for guidance on the semantics of > the stats to expose. RFC3813 details

Re: [PATCH net-next 1/2] mpls: packet stats

2016-02-19 Thread Robert Shearman
On 16/02/16 20:26, roopa wrote: On 2/16/16, 7:41 AM, David Miller wrote: Statistics not provided via netlink are useless in real installations. In fact I would say to forego the proc interface entirely, it's a second class citizen for statistics gathering and has a non-triviel per-device cost

Re: [PATCH net-next 1/2] mpls: packet stats

2016-02-16 Thread roopa
On 2/16/16, 7:41 AM, David Miller wrote: > Statistics not provided via netlink are useless in real installations. > > In fact I would say to forego the proc interface entirely, it's a second > class citizen for statistics gathering and has a non-triviel per-device > cost for instantiation. > +1 I

Re: [PATCH net-next 1/2] mpls: packet stats

2016-02-16 Thread David Miller
From: David Laight Date: Mon, 8 Feb 2016 11:51:34 + > From: Francois Romieu >> Sent: 06 February 2016 10:59 >> > +void mpls_stats_inc_outucastpkts(struct net_device *dev, >> > + const struct sk_buff *skb) >> > +{ >> > + struct mpls_dev

Re: [PATCH net-next 1/2] mpls: packet stats

2016-02-16 Thread David Miller
Statistics not provided via netlink are useless in real installations. In fact I would say to forego the proc interface entirely, it's a second class citizen for statistics gathering and has a non-triviel per-device cost for instantiation.

Re: [PATCH net-next 1/2] mpls: packet stats

2016-02-08 Thread Robert Shearman
On 06/02/16 10:58, Francois Romieu wrote: Robert Shearman : [...] diff --git a/net/mpls/Makefile b/net/mpls/Makefile index 9ca923625016..6fdd61b9eae3 100644 --- a/net/mpls/Makefile +++ b/net/mpls/Makefile [...] @@ -98,6 +94,29 @@ bool mpls_pkt_too_big(const struct

RE: [PATCH net-next 1/2] mpls: packet stats

2016-02-08 Thread David Laight
From: Francois Romieu > Sent: 06 February 2016 10:59 > > +void mpls_stats_inc_outucastpkts(struct net_device *dev, > > +const struct sk_buff *skb) > > +{ > > + struct mpls_dev *mdev; > > + struct inet6_dev *in6dev; > > Nit: the scope can be reduced for both

Re: [PATCH net-next 1/2] mpls: packet stats

2016-02-06 Thread Francois Romieu
Robert Shearman : [...] > diff --git a/net/mpls/Makefile b/net/mpls/Makefile > index 9ca923625016..6fdd61b9eae3 100644 > --- a/net/mpls/Makefile > +++ b/net/mpls/Makefile [...] > @@ -98,6 +94,29 @@ bool mpls_pkt_too_big(const struct sk_buff *skb, unsigned > int mtu) > } >

[PATCH net-next 1/2] mpls: packet stats

2016-02-05 Thread Robert Shearman
Having MPLS packet stats is useful for observing network operation and for diagnosing network problems. In the absence of anything better, use RFCs for MIBs defining MPLS stats for guidance on the semantics of the stats to expose. RFC3813 details two per-interface packet stats that should be