Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-21 Thread David Miller
From: Jiri Pirko Date: Tue, 15 Mar 2016 09:24:17 +0100 > Tue, Mar 15, 2016 at 09:08:44AM CET, ro...@cumulusnetworks.com wrote: >>Apart from the usability concern i have described earlier, this just seems an >>overkill ...having to redefine every attribute. > > I don't hear

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-16 Thread roopa
On 3/15/16, 1:20 AM, Nicolas Dichtel wrote: > Le 15/03/2016 07:30, roopa a écrit : >> On 3/14/16, 8:00 AM, Nicolas Dichtel wrote: >>> Le 13/03/2016 02:56, Roopa Prabhu a écrit : > [snip] diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread Jiri Pirko
Tue, Mar 15, 2016 at 09:08:44AM CET, ro...@cumulusnetworks.com wrote: >On 3/15/16, 12:52 AM, Jiri Pirko wrote: >> Tue, Mar 15, 2016 at 08:38:51AM CET, ro...@cumulusnetworks.com wrote: >>> >[snip] >>> how does it matter if we have reached an agreement that the struct is >>> required ?. >>> unlike

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread Nicolas Dichtel
Le 15/03/2016 07:30, roopa a écrit : On 3/14/16, 8:00 AM, Nicolas Dichtel wrote: Le 13/03/2016 02:56, Roopa Prabhu a écrit : [snip] diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index ca764b5..2bbb300 100644 --- a/include/uapi/linux/rtnetlink.h +++

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread roopa
On 3/15/16, 12:52 AM, Jiri Pirko wrote: > Tue, Mar 15, 2016 at 08:38:51AM CET, ro...@cumulusnetworks.com wrote: >> [snip] >> how does it matter if we have reached an agreement that the struct is >> required ?. >> unlike other messages, a filter_mask is an important and must attribute for >>

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread Jiri Pirko
Tue, Mar 15, 2016 at 08:38:51AM CET, ro...@cumulusnetworks.com wrote: >On 3/15/16, 12:28 AM, Jiri Pirko wrote: >> Tue, Mar 15, 2016 at 07:24:22AM CET, ro...@cumulusnetworks.com wrote: >>> On 3/14/16, 12:04 PM, Jiri Pirko wrote: Mon, Mar 14, 2016 at 07:45:23PM CET, ro...@cumulusnetworks.com

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread roopa
On 3/15/16, 12:28 AM, Jiri Pirko wrote: > Tue, Mar 15, 2016 at 07:24:22AM CET, ro...@cumulusnetworks.com wrote: >> On 3/14/16, 12:04 PM, Jiri Pirko wrote: >>> Mon, Mar 14, 2016 at 07:45:23PM CET, ro...@cumulusnetworks.com wrote: On 3/14/16, 7:51 AM, Jiri Pirko wrote: > Sun, Mar 13, 2016

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread Jiri Pirko
Tue, Mar 15, 2016 at 07:24:22AM CET, ro...@cumulusnetworks.com wrote: >On 3/14/16, 12:04 PM, Jiri Pirko wrote: >> Mon, Mar 14, 2016 at 07:45:23PM CET, ro...@cumulusnetworks.com wrote: >>> On 3/14/16, 7:51 AM, Jiri Pirko wrote: Sun, Mar 13, 2016 at 02:56:25AM CET, ro...@cumulusnetworks.com

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread roopa
On 3/14/16, 12:56 PM, David Miller wrote: > From: Jiri Pirko > Date: Mon, 14 Mar 2016 20:04:35 +0100 > >> I believe that using *any* structs to send over netlink is a mistake. >> Netlink is capable to transfer everything using attrs. Easy to compose, >> easy to parse. easy to

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread roopa
j...@mojatatu.com; da...@davemloft.net >> Subject: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to >> dump link stats >> >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> [snip] >> Future possible new types of stat attributes: >> - IF

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread roopa
On 3/14/16, 8:00 AM, Nicolas Dichtel wrote: > Le 13/03/2016 02:56, Roopa Prabhu a écrit : >> From: Roopa Prabhu >> >> This patch adds a new RTM_GETSTATS message to query link stats via netlink >> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK >>

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-15 Thread roopa
On 3/14/16, 12:04 PM, Jiri Pirko wrote: > Mon, Mar 14, 2016 at 07:45:23PM CET, ro...@cumulusnetworks.com wrote: >> On 3/14/16, 7:51 AM, Jiri Pirko wrote: >>> Sun, Mar 13, 2016 at 02:56:25AM CET, ro...@cumulusnetworks.com wrote: From: Roopa Prabhu This

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread Jiri Pirko
Mon, Mar 14, 2016 at 08:56:40PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 14 Mar 2016 20:04:35 +0100 > >> I believe that using *any* structs to send over netlink is a mistake. >> Netlink is capable to transfer everything using attrs. Easy to compose, >> easy

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread David Miller
From: Jiri Pirko Date: Mon, 14 Mar 2016 20:04:35 +0100 > I believe that using *any* structs to send over netlink is a mistake. > Netlink is capable to transfer everything using attrs. Easy to compose, > easy to parse. easy to extend. Couple of more bytes in the message? So

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread Jiri Pirko
Mon, Mar 14, 2016 at 07:45:23PM CET, ro...@cumulusnetworks.com wrote: >On 3/14/16, 7:51 AM, Jiri Pirko wrote: >> Sun, Mar 13, 2016 at 02:56:25AM CET, ro...@cumulusnetworks.com wrote: >>> From: Roopa Prabhu >>> >>> This patch adds a new RTM_GETSTATS message to query link

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread roopa
On 3/14/16, 7:51 AM, Jiri Pirko wrote: > Sun, Mar 13, 2016 at 02:56:25AM CET, ro...@cumulusnetworks.com wrote: >> From: Roopa Prabhu >> >> This patch adds a new RTM_GETSTATS message to query link stats via netlink > >from the kernel. RTM_NEWLINK also dumps stats today,

RE: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread Elad Raz
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Roopa Prabhu > Sent: Sunday, March 13, 2016 3:56 AM > To: netdev@vger.kernel.org > Cc: j...@mojatatu.com; da...@davemloft.net > Subject: [PATCH net-next 1/

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread Nicolas Dichtel
Le 13/03/2016 02:56, Roopa Prabhu a écrit : From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread Jiri Pirko
Sun, Mar 13, 2016 at 02:56:25AM CET, ro...@cumulusnetworks.com wrote: >From: Roopa Prabhu > >This patch adds a new RTM_GETSTATS message to query link stats via netlink >from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK >returns a lot more than just

[PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-12 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from