Re: [PATCH net-next 1/3] veth: Account for packet drops in ndo_xdp_xmit

2018-10-13 Thread Toshiaki Makita
On 18/10/13 (土) 16:48, Jesper Dangaard Brouer wrote: On Thu, 11 Oct 2018 18:36:48 +0900 Toshiaki Makita wrote: Use existing atomic drop counter. Since drop path is really an exceptional case here, I'm thinking atomic ops would not hurt the performance. Hmm... we try very hard not to add

Re: [PATCH net-next 1/3] veth: Account for packet drops in ndo_xdp_xmit

2018-10-13 Thread Jesper Dangaard Brouer
On Thu, 11 Oct 2018 18:36:48 +0900 Toshiaki Makita wrote: > Use existing atomic drop counter. Since drop path is really an > exceptional case here, I'm thinking atomic ops would not hurt the > performance. Hmm... we try very hard not to add atomic ops to XDP code path. The XDP_DROP case is also

[PATCH net-next 1/3] veth: Account for packet drops in ndo_xdp_xmit

2018-10-11 Thread Toshiaki Makita
Use existing atomic drop counter. Since drop path is really an exceptional case here, I'm thinking atomic ops would not hurt the performance. XDP packets and bytes are not counted in ndo_xdp_xmit, but will be accounted on rx side by the following commit. Signed-off-by: Toshiaki Makita ---