Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Nicolas Dichtel
Le 20/04/2016 11:57, Eric Dumazet a écrit : On Wed, 2016-04-20 at 11:44 +0200, Nicolas Dichtel wrote: Le 20/04/2016 11:33, Eric Dumazet a écrit : [snip] How have you tested your patch exactly ? As stated in the cover letter, I didn't test it. You certainly can test this, by tweaking HAVE_EF

Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Eric Dumazet
On Wed, 2016-04-20 at 11:44 +0200, Nicolas Dichtel wrote: > Le 20/04/2016 11:33, Eric Dumazet a écrit : > [snip] > > How have you tested your patch exactly ? > As stated in the cover letter, I didn't test it. You certainly can test this, by tweaking HAVE_EFFICIENT_UNALIGNED_ACCESS and adding anot

Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Nicolas Dichtel
Le 20/04/2016 11:33, Eric Dumazet a écrit : [snip] How have you tested your patch exactly ? As stated in the cover letter, I didn't test it. I guess David should have copied his original comment here. -* The nlattr header is 4 bytes in size, that's why we test -* if the skb->

Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Eric Dumazet
On Wed, 2016-04-20 at 10:57 +0200, Nicolas Dichtel wrote: > IS_ALIGN() returns true when the alignment is as expected. The pad > attribute should be added only when the alignment is not 8. > > Fixes: 35c5845957c7 ("net: Add helpers for 64-bit aligning netlink > attributes.") > Signed-off-by: Nico

[PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

2016-04-20 Thread Nicolas Dichtel
IS_ALIGN() returns true when the alignment is as expected. The pad attribute should be added only when the alignment is not 8. Fixes: 35c5845957c7 ("net: Add helpers for 64-bit aligning netlink attributes.") Signed-off-by: Nicolas Dichtel --- include/net/netlink.h | 2 +- 1 file changed, 1 inser