Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

2016-01-06 Thread Marcelo Ricardo Leitner
On Thu, Jan 07, 2016 at 01:01:11AM +0800, Xin Long wrote: > On Wed, Jan 6, 2016 at 2:38 AM, Vlad Yasevich wrote: > > On 12/30/2015 10:50 AM, Xin Long wrote: > >> tranport hashtbale will replace the association hashtable to do the > >> lookup for transport, and then get association by t->assoc, rha

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

2016-01-06 Thread Xin Long
On Wed, Jan 6, 2016 at 2:38 AM, Vlad Yasevich wrote: > On 12/30/2015 10:50 AM, Xin Long wrote: >> tranport hashtbale will replace the association hashtable to do the >> lookup for transport, and then get association by t->assoc, rhashtable >> apis will be used because of it's resizable, scalable a

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

2016-01-05 Thread Vlad Yasevich
On 12/30/2015 10:50 AM, Xin Long wrote: > tranport hashtbale will replace the association hashtable to do the > lookup for transport, and then get association by t->assoc, rhashtable > apis will be used because of it's resizable, scalable and using rcu. > > lport + rport + paddr will be the base h

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

2016-01-05 Thread Xin Long
On Thu, Dec 31, 2015 at 1:41 AM, Marcelo Ricardo Leitner wrote: > On Wed, Dec 30, 2015 at 11:50:46PM +0800, Xin Long wrote: > ... >> +void sctp_hash_transport(struct sctp_transport *t) >> +{ >> + struct sctp_sockaddr_entry *addr; >> + struct sctp_hash_cmp_arg arg; >> + >> + addr = list

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

2015-12-30 Thread David Miller
From: Eric Dumazet Date: Wed, 30 Dec 2015 11:57:31 -0500 > I am against using rhashtable in SCTP (or TCP) at this stage, given the > number of bugs we have with it. Come on Eric, we've largely dealt with all of these problems. I haven't seen a serious report in a while. -- To unsubscribe from t

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

2015-12-30 Thread Marcelo Ricardo Leitner
On Wed, Dec 30, 2015 at 11:50:46PM +0800, Xin Long wrote: ... > +void sctp_hash_transport(struct sctp_transport *t) > +{ > + struct sctp_sockaddr_entry *addr; > + struct sctp_hash_cmp_arg arg; > + > + addr = list_entry(t->asoc->base.bind_addr.address_list.next, > +

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

2015-12-30 Thread Eric Dumazet
On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote: > tranport hashtbale will replace the association hashtable to do the > lookup for transport, and then get association by t->assoc, rhashtable > apis will be used because of it's resizable, scalable and using rcu. > > lport + rport + paddr will be

[PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

2015-12-30 Thread Xin Long
tranport hashtbale will replace the association hashtable to do the lookup for transport, and then get association by t->assoc, rhashtable apis will be used because of it's resizable, scalable and using rcu. lport + rport + paddr will be the base hashkey to locate the chain, with net to protect on