Re: [PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-03-01 Thread Jiri Benc
On Mon, 29 Feb 2016 09:13:50 -0800, Tom Herbert wrote: > As defined now, GPB can't be used with VXLAN-GPE at all, but when I > read your patch it looks very much like GPB is being checked and > allowed in the VXLAN-GPE path. The fact that "if (vs->flags & > VXLAN_F_GBP)" always fails for VXLAN-GPE

Re: [PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-02-29 Thread Tom Herbert
On Mon, Feb 29, 2016 at 2:23 AM, Jiri Benc wrote: > On Sat, 27 Feb 2016 12:54:52 -0800, Tom Herbert wrote: >> Yes, but RCO has not been specified for VXLAN-GPE either > > As far as I can see, RCO will just work with VXLAN-GPE. But I have no > problem disallowing them to be set

Re: [PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-02-29 Thread Jiri Benc
On Sat, 27 Feb 2016 12:54:52 -0800, Tom Herbert wrote: > Yes, but RCO has not been specified for VXLAN-GPE either As far as I can see, RCO will just work with VXLAN-GPE. But I have no problem disallowing them to be set together, if you prefer that. > so the patch > does not correctly refuse

Re: [PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-02-27 Thread Tom Herbert
On Sat, Feb 27, 2016 at 12:54 PM, Tom Herbert wrote: > On Sat, Feb 27, 2016 at 11:31 AM, Jiri Benc wrote: >> On Fri, 26 Feb 2016 15:51:29 -0800, Tom Herbert wrote: >>> I don't think this is right. VXLAN-GPE is a separate protocol than >>> VXLAN, they are

Re: [PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-02-27 Thread Tom Herbert
On Sat, Feb 27, 2016 at 11:31 AM, Jiri Benc wrote: > On Fri, 26 Feb 2016 15:51:29 -0800, Tom Herbert wrote: >> I don't think this is right. VXLAN-GPE is a separate protocol than >> VXLAN, they are not compatible on the wire and don't share flags or >> fields (for instance GPB

Re: [PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-02-27 Thread Jiri Benc
On Fri, 26 Feb 2016 15:51:29 -0800, Tom Herbert wrote: > I don't think this is right. VXLAN-GPE is a separate protocol than > VXLAN, they are not compatible on the wire and don't share flags or > fields (for instance GPB uses bits in VXLAN that hold the next > protocol in VXLAN-GPE). Neither is

Re: [PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-02-26 Thread Tom Herbert
On Thu, Feb 25, 2016 at 11:48 PM, Jiri Benc wrote: > Implement VXLAN-GPE. Only L2 mode (i.e. encapsulated Ethernet frame) is > supported by this patch. > > L3 mode will be added by subsequent patches. > > Signed-off-by: Jiri Benc > --- > drivers/net/vxlan.c

[PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-02-25 Thread Jiri Benc
Implement VXLAN-GPE. Only L2 mode (i.e. encapsulated Ethernet frame) is supported by this patch. L3 mode will be added by subsequent patches. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 68 ++-- include/net/vxlan.h