Re: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread Roopa Prabhu
On Wed, May 24, 2017 at 6:10 PM, David Ahern wrote: > On 5/24/17 1:33 PM, Rosen, Rami wrote: >> Hi, Rupa /David Ahern, >> >> First, thanks for this patch set! >> >> Second, it seems to me that something might be incorrect here. >> >> You have these additions in this patch (1/8): >> ... >> +struct

Re: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/net-extend-RTM_GETROUTE-to-return-fib-result/20170525-053253 config: openrisc-or1ksim_defconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 5.4.0 reproduce: wget h

Re: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/net-extend-RTM_GETROUTE-to-return-fib-result/20170525-053253 config: cris-etrax-100lx_v2_defconfig (attached as .config) compiler: cris-linux-gcc (GCC) 6.2.0 reproduce: wget

Re: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread David Ahern
On 5/24/17 1:33 PM, Rosen, Rami wrote: > Hi, Rupa /David Ahern, > > First, thanks for this patch set! > > Second, it seems to me that something might be incorrect here. > > You have these additions in this patch (1/8): > ... > +struct rtable *ip_route_output_key_hash_rcu(struct net *net, struct

RE: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread Rosen, Rami
Hi, Rupa /David Ahern, First, thanks for this patch set! Second, it seems to me that something might be incorrect here. You have these additions in this patch (1/8): ... +struct rtable *ip_route_output_key_hash_rcu(struct net *net, struct flowi4 *flp, +

[PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread Roopa Prabhu
From: David Ahern A later patch wants access to the fib result on an output route lookup with the rcu lock held. Refactor __ip_route_output_key_hash, pushing the logic between rcu_read_lock ... rcu_read_unlock into a new helper that takes the fib_result as an input arg. To keep the name length u