Re: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

From: "Mintz, Yuval" Date: Fri, 9 Jun 2017 07:08:54 + > But one thing I thought of asking - do we consider layouts of relatively > insignificant structures to be some golden coding standard? It just shows lack of thought when writing things. I want to see code that

RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

v@vger.kernel.org; linux-r...@vger.kernel.org; Kalderon, Michal > > <michal.kalde...@cavium.com> > > Subject: RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx > > > > From: David Miller > > > Sent: 09 June 2017 00:24 > > >

RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

lderon, Michal > <michal.kalde...@cavium.com> > Subject: RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx > > From: David Miller > > Sent: 09 June 2017 00:24 > > > > From: Yuval Mintz <yuval.mi...@cavium.com> > > Date: Th

RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

From: David Miller > Sent: 09 June 2017 00:24 > > From: Yuval Mintz > Date: Thu, 8 Jun 2017 19:13:16 +0300 > > > @@ -67,6 +79,21 @@ struct qed_ll2_stats { > > u64 sent_bcast_pkts; > > }; > > > > +struct qed_ll2_tx_pkt_info { > > + u8 num_of_bds; > > + u16 vlan;

RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

> > +struct qed_ll2_tx_pkt_info { > > + u8 num_of_bds; > > + u16 vlan; > > + u8 bd_flags; > > + u16 l4_hdr_offset_w;/* from start of packet */ > > + enum qed_ll2_tx_dest tx_dest; > > + enum qed_ll2_roce_flavor_type qed_roce_flavor; > > + dma_addr_t first_frag; > > + u16

Re: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

From: Yuval Mintz Date: Thu, 8 Jun 2017 19:13:16 +0300 > @@ -67,6 +79,21 @@ struct qed_ll2_stats { > u64 sent_bcast_pkts; > }; > > +struct qed_ll2_tx_pkt_info { > + u8 num_of_bds; > + u16 vlan; > + u8 bd_flags; > + u16 l4_hdr_offset_w;/* from

[PATCH net-next 1/8] qed: LL2 to use packed information for tx

First step in revising the LL2 interface, this declares qed_ll2_tx_pkt_info as part of the ll2 interface, and uses it for transmission instead of receiving lots of parameters. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 127