Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Hannes Frederic Sowa
On 06.01.2016 22:01, Jesse Gross wrote: On Wed, Jan 6, 2016 at 12:25 PM, Hannes Frederic Sowa wrote: The refreshes from each module are completely synchronous and don't get interleaved, so as long as the driver is correctly handling the locking internally rtnl lock shouldn't be needed. But as I

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 12:25 PM, Hannes Frederic Sowa wrote: > On 06.01.2016 20:52, Jesse Gross wrote: >> On Wed, Jan 6, 2016 at 10:48 AM, Hannes Frederic Sowa >> wrote: >>> On 06.01.2016 19:00, Jesse Gross wrote: Unfortunately, I don't think that we can assume that RTNL is held here. I

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Hannes Frederic Sowa
Hi Jesse, hmpf, I saw your mail too late and send out another series just now. On 06.01.2016 20:52, Jesse Gross wrote: On Wed, Jan 6, 2016 at 10:48 AM, Hannes Frederic Sowa wrote: On 06.01.2016 19:00, Jesse Gross wrote: On Wed, Jan 6, 2016 at 7:41 AM, Hannes Frederic Sowa wrote: diff --g

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 10:48 AM, Hannes Frederic Sowa wrote: > On 06.01.2016 19:00, Jesse Gross wrote: >> >> On Wed, Jan 6, 2016 at 7:41 AM, Hannes Frederic Sowa >> wrote: >>> >>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >>> index 24b077a32c1c9c..548925d1571cb1 100644 >>> --- a/dr

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Hannes Frederic Sowa
On 06.01.2016 19:00, Jesse Gross wrote: On Wed, Jan 6, 2016 at 7:41 AM, Hannes Frederic Sowa wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 24b077a32c1c9c..548925d1571cb1 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c +static int geneve_notifier(struct notif

Re: [PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Jesse Gross
On Wed, Jan 6, 2016 at 7:41 AM, Hannes Frederic Sowa wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 24b077a32c1c9c..548925d1571cb1 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > +static int geneve_notifier(struct notifier_block *unused, > +

[PATCH net-next 2/2] geneve: break dependency to network drivers

2016-01-06 Thread Hannes Frederic Sowa
Signed-off-by: Hannes Frederic Sowa --- drivers/net/geneve.c | 30 +++--- include/linux/netdevice.h | 1 + include/net/geneve.h | 7 +++ 3 files changed, 31 insertions(+), 7 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 24b077