Re: [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-30 Thread Jesse Gross
On Wed, Sep 30, 2015 at 2:05 PM, Jiri Benc wrote: > On Wed, 30 Sep 2015 13:18:40 -0700, Jesse Gross wrote: >> This function is used to report back information that is the result of >> the encapsulation process, such as the UDP source port chosen. Take a >> look at net/openvswitch/actions.c:output_

Re: [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-30 Thread Jiri Benc
On Wed, 30 Sep 2015 13:18:40 -0700, Jesse Gross wrote: > This function is used to report back information that is the result of > the encapsulation process, such as the UDP source port chosen. Take a > look at net/openvswitch/actions.c:output_userspace(), particularly the > OVS_USERSPACE_ATTR_EGRES

Re: [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-30 Thread Jesse Gross
On Wed, Sep 30, 2015 at 12:28 AM, Jiri Benc wrote: > On Tue, 29 Sep 2015 20:05:00 -0700, Jesse Gross wrote: >> This appears to me to be a bug in the existing code. >> ovs_tunnel_get_egress_info() as a general mechanism is still in use >> and should work with both the old and new configuration meth

Re: [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-30 Thread Jiri Benc
On Tue, 29 Sep 2015 20:05:00 -0700, Jesse Gross wrote: > This appears to me to be a bug in the existing code. > ovs_tunnel_get_egress_info() as a general mechanism is still in use > and should work with both the old and new configuration methods. It's currently used only from the compat layer (the

Re: [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-29 Thread Jesse Gross
On Tue, Sep 29, 2015 at 10:52 AM, Jiri Benc wrote: > When compat code for tunnel configuration is used, IPv6 tun_info will be > rejected by ovs_tunnel_get_egress_info. As the consequence, only the new way > of tunnel config supports IPv6. This appears to me to be a bug in the existing code. ovs_t

[PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-29 Thread Jiri Benc
Add netlink attributes for IPv6 tunnel addresses. This enables IPv6 support for tunnels. When compat code for tunnel configuration is used, IPv6 tun_info will be rejected by ovs_tunnel_get_egress_info. As the consequence, only the new way of tunnel config supports IPv6. Signed-off-by: Jiri Benc