Re: [PATCH net-next 2/3] net: dsa: mediatek: combine MediaTek tag with VLAN tag

2017-12-12 Thread Sean Wang
On Tue, 2017-12-12 at 09:28 +0100, Andrew Lunn wrote: > On Tue, Dec 12, 2017 at 03:21:21PM +0800, Sean Wang wrote: > > On Thu, 2017-12-07 at 16:30 +0100, Andrew Lunn wrote: > > > > @@ -25,20 +28,37 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff > > > > *skb, > > > > { > > > >

Re: [PATCH net-next 2/3] net: dsa: mediatek: combine MediaTek tag with VLAN tag

2017-12-12 Thread Andrew Lunn
On Tue, Dec 12, 2017 at 03:21:21PM +0800, Sean Wang wrote: > On Thu, 2017-12-07 at 16:30 +0100, Andrew Lunn wrote: > > > @@ -25,20 +28,37 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff > > > *skb, > > > { > > > struct dsa_port *dp = dsa_slave_to_port(dev); > > > u8 *mtk_tag; > > > +

Re: [PATCH net-next 2/3] net: dsa: mediatek: combine MediaTek tag with VLAN tag

2017-12-11 Thread Sean Wang
On Thu, 2017-12-07 at 16:30 +0100, Andrew Lunn wrote: > > @@ -25,20 +28,37 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff *skb, > > { > > struct dsa_port *dp = dsa_slave_to_port(dev); > > u8 *mtk_tag; > > + bool is_vlan_skb = true; > > .. > > > + /* Mark tag attribute on

Re: [PATCH net-next 2/3] net: dsa: mediatek: combine MediaTek tag with VLAN tag

2017-12-07 Thread Andrew Lunn
> @@ -25,20 +28,37 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff *skb, > { > struct dsa_port *dp = dsa_slave_to_port(dev); > u8 *mtk_tag; > + bool is_vlan_skb = true; .. > + /* Mark tag attribute on special tag insertion to notify hardware > + * whether that's a

[PATCH net-next 2/3] net: dsa: mediatek: combine MediaTek tag with VLAN tag

2017-12-06 Thread sean.wang
From: Sean Wang In order to let MT7530 switch can recognize well those packets having both special tag and VLAN tag, the information about the special tag should be carried on the existing VLAN tag. Signed-off-by: Sean Wang --- net/dsa/tag_mtk.c