Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-14 Thread Vivien Didelot
Hi Sean, Sean Wang writes: >> This won't apply, the port index in now stored in p->dp->index. > > It seems that I need to upgrade to newer kernel to verify this Correct. In fact every time you send patches to net-next (or any other subsystem branch), you must rebase

Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-14 Thread Sean Wang
On Mon, 2017-03-13 at 12:59 -0400, Vivien Didelot wrote: > Hi Sean, > > sean.w...@mediatek.com writes: > > > + mtk_tag[1] = (1 << p->port) & MTK_HDR_XMIT_DP_BIT_MASK; > > This won't apply, the port index in now stored in p->dp->index. > > Thanks, > > Vivien Hi Vivien, It seems

Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-14 Thread Sean Wang
On Mon, 2017-03-13 at 09:35 -0700, Florian Fainelli wrote: > On 03/13/2017 09:11 AM, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Add the support for the 4-bytes tag for DSA port distinguishing inserted > > allowing receiving and transmitting the packet via

Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-13 Thread Vivien Didelot
Hi Sean, sean.w...@mediatek.com writes: > + mtk_tag[1] = (1 << p->port) & MTK_HDR_XMIT_DP_BIT_MASK; This won't apply, the port index in now stored in p->dp->index. Thanks, Vivien

Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-13 Thread Florian Fainelli
On 03/13/2017 09:11 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Add the support for the 4-bytes tag for DSA port distinguishing inserted > allowing receiving and transmitting the packet via the particular port. > The tag is being added after the source MAC

Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-13 Thread Andrew Lunn
On Tue, Mar 14, 2017 at 12:11:26AM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Add the support for the 4-bytes tag for DSA port distinguishing inserted > allowing receiving and transmitting the packet via the particular port. > The tag is being added after

[PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-13 Thread sean.wang
From: Sean Wang Add the support for the 4-bytes tag for DSA port distinguishing inserted allowing receiving and transmitting the packet via the particular port. The tag is being added after the source MAC address in the ethernet header. Signed-off-by: Sean Wang