Re: [PATCH net-next 2/4] nfp: register ports as devlink ports

2017-05-25 Thread Jiri Pirko
Wed, May 24, 2017 at 09:24:13PM CEST, kubak...@wp.pl wrote: >On Wed, 24 May 2017 14:35:14 +0200, Jiri Pirko wrote: >> >+void nfp_devlink_port_unregister(struct nfp_port *port) >> >+{ >> >+ /* Due to unpleasant lock ordering we may see the port go away before >> >+* we have fully probed. >>

Re: [PATCH net-next 2/4] nfp: register ports as devlink ports

2017-05-24 Thread Jakub Kicinski
On Wed, 24 May 2017 14:35:14 +0200, Jiri Pirko wrote: > >+void nfp_devlink_port_unregister(struct nfp_port *port) > >+{ > >+/* Due to unpleasant lock ordering we may see the port go away before > >+ * we have fully probed. > > Could you elaborate on this a bit more please? It's partiall

Re: [PATCH net-next 2/4] nfp: register ports as devlink ports

2017-05-24 Thread Jiri Pirko
Tue, May 23, 2017 at 05:12:45PM CEST, jakub.kicin...@netronome.com wrote: >Extend nfp_port to contain devlink_port structures. Register the >ports to allow users inspecting device ports. > >Signed-off-by: Jakub Kicinski >Reviewed-by: Simon Horman >--- [...] >+void nfp_devlink_port_unregister(s

[PATCH net-next 2/4] nfp: register ports as devlink ports

2017-05-23 Thread Jakub Kicinski
Extend nfp_port to contain devlink_port structures. Register the ports to allow users inspecting device ports. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 49 +++ drivers/net/ethernet/netronome/nfp/nfp_main